Skip to content

Conversation

lqd
Copy link
Member

@lqd lqd commented Feb 21, 2023

#107956 has introduced an error in bootstrap when benchmarking rustc in rustc-perf so this PR tries to revert it to fix #108258.

This reverts commit 6990ab9.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 21, 2023
@lqd
Copy link
Member Author

lqd commented Feb 21, 2023

Let's see if this brings back the bootstrap timings as it should:

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2023
@bors
Copy link
Collaborator

bors commented Feb 21, 2023

⌛ Trying commit 2c75780 with merge 657d45bedc0c14aa3cded719ec1f8d34dd7751ad...

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@lqd
Copy link
Member Author

lqd commented Feb 21, 2023

Ah this is already being done in #108280 I'll close it.

@lqd lqd closed this Feb 21, 2023
@lqd lqd deleted the rustc-benchmark branch February 28, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc-perf fails to build after #107956
4 participants