Skip to content

[EXPERIMENT] Enable frame pointers for rustc #108497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Noratrieb
Copy link
Member

Let's see the impact on

  • perfing the dist build
  • performance

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 26, 2023
@Noratrieb
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2023
@bors
Copy link
Collaborator

bors commented Feb 26, 2023

⌛ Trying commit 8b110bf with merge f5b5d154053cc0cdf83bf936023ef1e100428d96...

@Dylan-DPC
Copy link
Member

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

Failed to set assignee to ghost: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@Dylan-DPC Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
@marmeladema
Copy link
Contributor

@bors
Copy link
Collaborator

bors commented Feb 26, 2023

☀️ Try build successful - checks-actions
Build commit: f5b5d154053cc0cdf83bf936023ef1e100428d96 (f5b5d154053cc0cdf83bf936023ef1e100428d96)

@rust-timer

This comment has been minimized.

@Noratrieb
Copy link
Member Author

This is indeed a duplicate of that PR, I wasn't able to find it before I opened this one

@Noratrieb Noratrieb closed this Feb 26, 2023
@Noratrieb Noratrieb deleted the pointer-framing branch February 26, 2023 20:26
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f5b5d154053cc0cdf83bf936023ef1e100428d96): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [0.5%, 3.6%] 191
Regressions ❌
(secondary)
1.6% [0.5%, 3.1%] 194
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.7% [0.5%, 3.6%] 191

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [1.8%, 2.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.7% [-4.8%, -4.7%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.1%, 2.1%] 6
Regressions ❌
(secondary)
1.7% [1.3%, 2.8%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.6% [1.1%, 2.1%] 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants