Update Clippy #110003

flip1995 · 2023-04-06T11:44:07Z

It is possible to use conditional compilation to prevent Clippy from evaluating certain code. This adds a brief explanation of how to use the feature with conditional compilation, and mentions that generally it’s preferable to use something like `#[allow(clippy::all)]`. Fixes rust-lang#10220 — Ability to skip files or blocks entirely

Rename method to `is_range_full` because the type is actually `RangeFull`. Method moved to `clippy_utils` for reuse in `clear_with_drain`.

Use `split-debuginfo = "unpacked"` for debug builds On Windows this has no effect as it's unsupported. On macOS the default set by cargo is already unpacked so no effect there either For Linux it shaves a bit off the rebuild time, for me in the case of a simple `touch` + `cargo build` it goes from 12s to 10s It saves a good amount of disk space too, on `aarch64-unknown-linux-gnu` it saves 1.2GB for a plain `cargo build`, 3GB when also running `cargo dev` and `cargo test --no-run -F internal` r? `@flip1995` changelog: none

changelog: fix: Replace the nonexistent `allowed-locales` in the `DISALLOWED_SCRIPT_IDENTS` docs with `allowed-scripts`.

docs fix: unknown field `allowed-locales` changelog: [`DISALLOWED_SCRIPT_IDENTS`]: Replace the nonexistent `allowed-locales` in the docs with `allowed-scripts`.

…ng from float suggest `try_into` when casting to wildcard type; fix [`cast_possible_truncation`] suggesting useless parenthesis; remove suggesting for float to float conversion in [`cast_possible_truncation`] style nit

…tr-casts-parens, r=Jarcho Wrap `transmutes_expressible_as_ptr_casts` suggestions in parentheses changelog: [`transmutes_expressible_as_ptr_casts`]: Fix suggestion missing wrapping parentheses Fixes rust-lang#10449 r? `@Jarcho` Is this the best way to go about this? `unused_parens` will catch the unnecessary ones but emitting them in the first place isn't ideal

Add explanation on how to run `cargo-clippy` and `clippy-driver` I don't know how this would be done on Windows or MacOS, feedback appreciated. I did find this snippet for MacOS but it seems a little sketchy. https://github.com/rust-lang/rust-clippy/blob/1d1e72308e5bcdf5abe95c1d29dfe82524940061/.github/workflows/clippy_bors.yml#L98-L102 changelog: none

fix [`cast_possible_truncation`] offering wrong suggestion for casting float to integer fixes: rust-lang#10366 --- changelog: [`cast_possible_truncation`] Fix incorrect suggestions when casting from float types or to `_`

Make this function work with signed integer types by extracting the underlying type and finding the min and max values. Change the signature to make it more consistent: - The range is now given as an `Expr` in order to extract the type - The container's path is now passed, and only as an `Option` so that the function can be called in the general case without a container

Co-authored-by: llogiq <bogusandre@gmail.com>

Add `max_line_length` to `.editorconfig`, matching `rustfmt.toml` Add `max_line_length` to `.editorconfig` to match the `max_width` in `rustfmt.toml`. changelog: none

[missing_const_for_fn] fix rust-lang#7121 *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`missing_const_for_fn`] note about removing const may break compatibility fix rust-lang#7121

…r=xFrednet remove unusued `#![feature(drain_filter)]` The unstable feature does not appear to be used and its presence blocks work in rust-lang#104455 changelog: none

…dnet fix(needless_return): do not trigger on ambiguous match arms return If we see a case where match returns something other than `()`, we just skip `needless_return` lint in that case Should fix rust-lang#10546 Relevant Zulip Discussion: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Issue.20.2310546 --- changelog: FP: [`needless_return`]: No longer lints match statements with incompatible branches [rust-lang#10593](rust-lang/rust-clippy#10593)

Clear with drain Fixes rust-lang#10572: both the original intent of the issue (extending `clear_with_drain`) and the false negative for `collection_is_never_read` I found in the process are fixed by this PR. changelog: [`clear_with_drain`]: extend to 5 other types of containers. [`collection_is_never_read`]: fix false negative for `String`s.

…t_type, r=Manishearth `collection_is_never_read`: Handle unit type changelog: [`collection_is_never_read`]: Fix false negative fixes: rust-lang#10488

Links to README.md files must actually be links to index.md files, because of the inner workings of `mdbook`. Also use the latest mdbook version in CI.

Fix links in Clippy book Links to README.md files must actually be links to index.md files, because of the inner workings of `mdbook`. Also use the latest mdbook version in CI. --- Blocks rust-lang#110003 (comment) changelog: none

flip1995 · 2023-04-11T14:35:57Z

@Manishearth CI is passing now 🚀

Manishearth · 2023-04-11T15:02:28Z

@bors r+

bors · 2023-04-11T15:02:30Z

📌 Commit c355e6b has been approved by Manishearth

It is now in the queue for this repository.

matthiaskrgr · 2023-04-11T15:32:37Z

@bors p=10

bors · 2023-04-11T16:51:26Z

⌛ Testing commit c355e6b with merge 87a2408...

bors · 2023-04-11T19:16:32Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 87a2408 to master...

rust-timer · 2023-04-11T20:32:27Z

Finished benchmarking commit (87a2408): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.9%, 0.9%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-2.0%	[-2.5%, -1.5%]	2
Improvements ✅ (secondary)	-6.9%	[-6.9%, -6.9%]	1
All ❌✅ (primary)	-2.0%	[-2.5%, -1.5%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.5%, 0.5%]	4

danielparks and others added 30 commits February 11, 2023 07:50

Remove the NodeId of ast::ExprKind::Async

1e17a44

add large future lint

4fdae81

Create clear_with_drain lint

7f44530

Pull is_full_range method from iter_with_drain

85d4281

Rename method to `is_range_full` because the type is actually `RangeFull`. Method moved to `clippy_utils` for reuse in `clear_with_drain`.

Add tests to cover all cases

589d7e1

Update lint declaration

484c82e

Add the lint logic

c7e3e30

Add test for partial range

1d0acce

Finish tests - add rustfix

e8ec242

Merge branch 'rust-lang:master' into clear-with-drain

d56c941

Use split-debuginfo = "unpacked" for debug builds

a90e5cc

Wrap transmutes_expressible_as_ptr_casts suggestions in parentheses

ecc2012

A MIR transform that checks pointers are aligned

765c6b8

Fix clippy

f96e38b

Add suggestions to extra_unused_type_parameters

50d92d0

Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup

8df896c

docs fix: unknown field allowed-locales

982c81a

changelog: fix: Replace the nonexistent `allowed-locales` in the `DISALLOWED_SCRIPT_IDENTS` docs with `allowed-scripts`.

Fix allow attribute, items from macros in items_after_statements

b13f99c

Add explanation on how to run cargo-clippy and clippy-driver

b782a07

Auto merge of rust-lang#10541 - FixedThink:patch-1, r=llogiq

ed6c15a

docs fix: unknown field `allowed-locales` changelog: [`DISALLOWED_SCRIPT_IDENTS`]: Replace the nonexistent `allowed-locales` in the docs with `allowed-scripts`.

Move unnecessary_struct_initialization to nursery

a6f56cb

Merge branch 'rust-lang:master' into clear-with-drain

1d168b3

Add some tests

ee0de53

KisaragiEffective and others added 11 commits April 10, 2023 01:31

apply code review suggestion

ba1f19e

Co-authored-by: llogiq <bogusandre@gmail.com>

Auto merge of rust-lang#10610 - beetrees:max-line-length, r=Jarcho

7de7ca8

Add `max_line_length` to `.editorconfig`, matching `rustfmt.toml` Add `max_line_length` to `.editorconfig` to match the `max_width` in `rustfmt.toml`. changelog: none

remove unusued feature

d6fe73d

Auto merge of rust-lang#10624 - the8472:remove-drain-filter-feature, …

4904d75

…r=xFrednet remove unusued `#![feature(drain_filter)]` The unstable feature does not appear to be used and its presence blocks work in rust-lang#104455 changelog: none

Refactor

63030ac

Ignore fake read access

008ba73

Add test case from rust-lang#10488

3d71145

Auto merge of rust-lang#10492 - schubart:collection_is_never_read_uni…

3b5b2ed

…t_type, r=Manishearth `collection_is_never_read`: Handle unit type changelog: [`collection_is_never_read`]: Fix false negative fixes: rust-lang#10488

flip1995 force-pushed the clippyup branch from 2d3022a to 3ef529d Compare April 11, 2023 11:41

flip1995 mentioned this pull request Apr 11, 2023

Fix links in Clippy book rust-lang/rust-clippy#10630

Merged

flip1995 and others added 4 commits April 11, 2023 14:43

Fix links in Clippy book

0266a9e

Links to README.md files must actually be links to index.md files, because of the inner workings of `mdbook`. Also use the latest mdbook version in CI.

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

0ca8ae5

Update Cargo.lock

c355e6b

flip1995 force-pushed the clippyup branch from 3ef529d to c355e6b Compare April 11, 2023 13:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 11, 2023

bors merged commit 87a2408 into rust-lang:master Apr 11, 2023

rustbot added this to the 1.70.0 milestone Apr 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #110003

Update Clippy #110003

flip1995 commented Apr 6, 2023

flip1995 commented Apr 11, 2023

Manishearth commented Apr 11, 2023

bors commented Apr 11, 2023

matthiaskrgr commented Apr 11, 2023

bors commented Apr 11, 2023

bors commented Apr 11, 2023

rust-timer commented Apr 11, 2023

Update Clippy #110003

Update Clippy #110003

Conversation

flip1995 commented Apr 6, 2023

flip1995 commented Apr 11, 2023

Manishearth commented Apr 11, 2023

bors commented Apr 11, 2023

matthiaskrgr commented Apr 11, 2023

bors commented Apr 11, 2023

bors commented Apr 11, 2023

rust-timer commented Apr 11, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles