Skip to content

Skip installing rustc stage 0 #110526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Skip installing rustc stage 0 #110526

wants to merge 1 commit into from

Conversation

ecnelises
Copy link
Contributor

Installing rustc stage 0 is meaningless to bootstrap but actually confusing sometimes. Currently bootstrap leaves a dir-not-found error when installing compiler/rustc with stage set to 0:

Building bootstrap
   Compiling bootstrap v0.0.0 (rust/src/bootstrap)
    Finished dev [unoptimized] target(s) in 1.90s
thread 'main' panicked at 'could not read dir "rust/build/aarch64-apple-darwin/stage0-sysroot/bin": Os { code: 2, kind: NotFound, message: "No such file or directory" }', lib.rs:1550:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Skip it proactively to avoid confusion.

@ecnelises
Skip installing rustc stage 0
24264d8 
Installing rustc stage 0 is meaningless to bootstrap but actually
confusing sometimes. Currently bootstrap leaves a dir-not-found error
when installing compiler/rustc with stage set to 0. Skip it proactively
to avoid confusion.
@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 19, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 26, 2023

Why would you ever run x install --stage 0? If we're going to make changes here, I'd expect the change to be giving a hard error at startup, not just a warning in this single step.

@albertlarsan68 albertlarsan68 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
@ecnelises ecnelises closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecnelises @rustbot @jyn514 @albertlarsan68