Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tracking UI test for upstream LLVM issue #110790

Closed
wants to merge 1 commit into from
Closed

add tracking UI test for upstream LLVM issue #110790

wants to merge 1 commit into from

Conversation

Ezrashaw
Copy link
Contributor

Adds a tracking test for #110743 while we wait for it to be fixed upstream (I will be doing that) and those changes to be brought into rustc.

cc #110743

r? @matthiaskrgr

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 25, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 4, 2023

☔ The latest upstream changes (presumably #111169) made this pull request unmergeable. Please resolve the merge conflicts.

@Ezrashaw
Copy link
Contributor Author

Ezrashaw commented May 6, 2023 •
edited
Loading

It's been two weeks, I'll reroll for someone less busy.

r? compiler

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2023

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot rustbot assigned TaKO8Ki and unassigned matthiaskrgr May 6, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 9, 2023

☔ The latest upstream changes (presumably #111402) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2023
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Jun 13, 2023

Sorry for the late reply. r=me after the conflicts are addressed.

@JohnCSimon
Copy link
Member

@Ezrashaw
ping from triage - can you post your status on this PR? There hasn't been an update in a few months and there are merge conflicts. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@Ezrashaw
Copy link
Contributor Author

@JohnCSimon To be honest, this PR can probably be closed. The fix is in upstream LLVM, once we get that this will be fixed. A test is pretty redundant.

@Ezrashaw Ezrashaw closed this Aug 28, 2023
@Ezrashaw Ezrashaw deleted the track-llvm-dbg-issue branch May 13, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Ezrashaw @rust-log-analyzer @bors @rustbot @TaKO8Ki @JohnCSimon @matthiaskrgr @Dylan-DPC