Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests #111558

Merged
merged 3 commits into from
May 30, 2023
Merged

Move tests #111558

merged 3 commits into from
May 30, 2023

Conversation

c410-f3r
Copy link
Contributor

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2023
WaffleLapkin
WaffleLapkin reviewed May 16, 2023
View reviewed changes
tests/ui/mir/issue-29798.rs Outdated Show resolved Hide resolved
tests/ui/recursion/issue-3008-1.rs Outdated Show resolved Hide resolved
tests/ui/typeck/issue-2063-resource.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the test doesn't contain any autoref anymore, even though it should test for it... The move seems fine though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is from 2012 and doesn't seem relevant anymore.

@WaffleLapkin WaffleLapkin self-assigned this May 16, 2023
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2023
@c410-f3r
Copy link
Contributor Author

Thanks for the review @WaffleLapkin

@WaffleLapkin
Copy link
Member

@c410-f3r what's the status here? will you address (the first two) of my comments?

@c410-f3r
Copy link
Contributor Author

c410-f3r commented May 29, 2023 •
edited
Loading

@c410-f3r what's the status here? will you address (the first two) of my comments?

Hahahaha, they were addressed since my last comment but I didn't push any changes 😵‍💫

@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 29, 2023

📌 Commit c62d49e has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 29, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2023
@bors
Auto merge of rust-lang#112080 - matthiaskrgr:rollup-pmpbe49, r=matth…
d9a4d5e 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111558 (Move tests)
 - rust-lang#111827 (Add build instructions for cranelift backend as part of Rust repo)
 - rust-lang#111988 (Make `TyKind: Debug` have less verbose output)
 - rust-lang#112022 (Check nested obligations during coercion unify in new solver)
 - rust-lang#112057 (Suggest correct `self_ty`)
 - rust-lang#112063 (Add a test for issue 110457/incremental ICE with closures with the same span)

Failed merges:

 - rust-lang#112068 (Move tests from `ui/discrim` dir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9e47e90 into rust-lang:master May 30, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin left review comments

Assignees

@petrochenkov petrochenkov

@WaffleLapkin WaffleLapkin

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@c410-f3r @WaffleLapkin @bors @petrochenkov @rustbot