Skip to content

Conversation

klensy
Copy link
Contributor

@klensy klensy commented May 18, 2023

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 18, 2023
@rust-log-analyzer

This comment has been minimized.

@clubby789
Copy link
Contributor

Looks like the version of Git in CI is 2.34.1, and this option was added in git 2.40.0.

@klensy klensy changed the title use git --object-only instead of manually carving hashes use git ls-tere --format instead of manually carving hashes May 18, 2023
@klensy klensy changed the title use git ls-tere --format instead of manually carving hashes use git ls-tree --format instead of manually carving hashes May 18, 2023
@clubby789
Copy link
Contributor

I'm not sure --format is available either; https://git-scm.com/docs/git-ls-tree/2.34.1

@klensy
Copy link
Contributor Author

klensy commented May 18, 2023

I'm not sure --format is available either; https://git-scm.com/docs/git-ls-tree/2.34.1

CI runner is 2.40.1, but dockered ubuntu 22.04 is 2.34.1, yeah.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling clap v4.2.4
   Compiling clap_complete v4.2.2
    Finished dev [unoptimized] target(s) in 14.97s
##[endgroup]
error: unknown option `format=%(objectname)'
usage: git ls-tree [<options>] <tree-ish> [<path>...]

    -d                    only show trees
    -r                    recurse into subtrees
    -t                    show trees when recursing
    -z                    terminate entries with NUL byte
    -l, --long            include object size
    --name-only           list only filenames
    --name-status         list only filenames
    --full-name           use full path names
    --full-tree           list entire tree; not just current directory (implies --full-name)
    --abbrev[=<n>]        use <n> digits to display object names

thread 'main' panicked at 'command did not execute successfully: cd "/checkout" && "git" "ls-tree" "HEAD" "src/tools/cargo" "--format=%(objectname)"
expected success, got: exit status: 129', lib.rs:550:27
Build completed unsuccessfully in 0:00:25

@klensy
Copy link
Contributor Author

klensy commented May 18, 2023

Sad.

@klensy klensy closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants