Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: remove dependency is-terminal #112309

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Jun 5, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 5, 2023
@albertlarsan68
Copy link
Member

r? @albertlarsan68
Thanks for the PR!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 5, 2023

📌 Commit edf342a has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2023
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#112034 (Migrate `item_opaque_ty` to Askama)
 - rust-lang#112179 (Avoid passing --cpu-features when empty)
 - rust-lang#112309 (bootstrap: remove dependency `is-terminal`)
 - rust-lang#112388 (Migrate GUI colors test to original CSS color format)
 - rust-lang#112389 (Add a test for rust-lang#105709)
 - rust-lang#112392 (Fix ICE for while loop with assignment condition with LHS place expr)
 - rust-lang#112394 (Remove accidental comment)
 - rust-lang#112396 (Track more diagnostics in `rustc_expand`)
 - rust-lang#112401 (Don't `use compile_error as print`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 737dbb0 into rust-lang:master Jun 8, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 8, 2023
@kadiwa4 kadiwa4 deleted the remove_is_terminal branch June 8, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants