Track more diagnostics in rustc_expand
#112396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler/rustc_expand/src/base.rs
Outdated
| @@ -1132,11 +1132,13 @@ impl<'a> ExtCtxt<'a> { | |||
| /// | |||
| /// Compilation will be stopped in the near future (at the end of | |||
| /// the macro expansion phase). | |||
| #[track_caller] | |||
There was a problem hiding this comment.
should we just go thru and add it to like all of them?
or at least like create_err, emit_err?
There was a problem hiding this comment.
span_bug and bug don't have #[track_caller], so this does not matter.
For struct_span_err, create_err and emit_err I've added #[track_caller], good call, thanks!
rust-cloud-vms
bot
force-pushed
the
track_more_diagnostics
branch
from
3e20f15
to
c38d80e
Compare
|
r? @compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 8, 2023
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#112034 (Migrate `item_opaque_ty` to Askama) - rust-lang#112179 (Avoid passing --cpu-features when empty) - rust-lang#112309 (bootstrap: remove dependency `is-terminal`) - rust-lang#112388 (Migrate GUI colors test to original CSS color format) - rust-lang#112389 (Add a test for rust-lang#105709) - rust-lang#112392 (Fix ICE for while loop with assignment condition with LHS place expr) - rust-lang#112394 (Remove accidental comment) - rust-lang#112396 (Track more diagnostics in `rustc_expand`) - rust-lang#112401 (Don't `use compile_error as print`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wish we could lint this somehow...