Skip to content

Conversation

compiler-errors
Copy link
Member

Fixes #111149

@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2023

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 5, 2023
@@ -3,6 +3,8 @@ error[E0559]: variant `Option<_>::None` has no field named `value`
|
LL | None { value: (), ..Default::default() }.await;
| ^^^^^ `Option<_>::None` does not have this field
|
= note: all struct fields are already assigned
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this could be a span-suggestion to remove the field altogether, but honestly I'm fine with just letting the programmer decide what to do with this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making a suggestion would be better, but it's fine as-is

@@ -3,6 +3,8 @@ error[E0559]: variant `Option<_>::None` has no field named `value`
|
LL | None { value: (), ..Default::default() }.await;
| ^^^^^ `Option<_>::None` does not have this field
|
= note: all struct fields are already assigned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making a suggestion would be better, but it's fine as-is

@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 8, 2023

📌 Commit 140c011 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 9, 2023
…ields, r=WaffleLapkin

Don't mention already-set fields in struct constructor missing field error

Fixes rust-lang#111149
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#112323 (Don't mention already-set fields in struct constructor missing field error)
 - rust-lang#112395 (Add Terminator::InlineAsm conversion from MIR to SMIR)
 - rust-lang#112411 (add programmerjake to portable-simd cc list)
 - rust-lang#112428 (Structurally resolve pointee in `check_pat_lit`)
 - rust-lang#112444 (Don't debug-print `Interned` or `PrivateZst`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 17cc282 into rust-lang:master Jun 9, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 9, 2023
@compiler-errors compiler-errors deleted the dont-mention-set-fields branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip filled in fields when suggesting field names
4 participants