CI: cancel in-progress workflow runs after a push #112955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Looks like it works. https://github.com/rust-lang/rust/actions/runs/5354873599/jobs/9712454947?pr=112955 was cancelled after the push of c579865. |
Kobzol
force-pushed
the
ci-pr-cancel-workflows
branch
from
c579865
to
3c2b8b0
Compare
|
rust-lang/simpleinfra#303 shouldn't cancel-outdated-build work similarly? |
|
Oh, thanks, I didn't notice. Well, it doesn't seem to work currently. |
|
Except that currently there idea that failling mingw-check-tidy should't fail other PR jobs. |
|
@bors try |
|
⌛ Trying commit fcfa036ad401722f60a1e6178d186a1ca988a32d with merge fa12c2abed4b7027ba6136d4208bf010f02a9913... |
This comment has been minimized.
This comment has been minimized.
Kobzol
force-pushed
the
ci-pr-cancel-workflows
branch
from
fcfa036
to
1f6e054
Compare
Kobzol
force-pushed
the
ci-pr-cancel-workflows
branch
from
1f6e054
to
e8973ea
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 26, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111326 (Add support for NetBSD/aarch64-be (big-endian arm64).) - rust-lang#112559 (Add esp-idf missing targets) - rust-lang#112840 (doc: loongarch: Update maintainers) - rust-lang#112955 (CI: cancel in-progress workflow runs after a push) - rust-lang#112979 (Rewrite most diagnostics as translatable within resolve/imports) - rust-lang#113034 (Switch some more Steps to `builder.msg`) r? `@ghost` `@rustbot` modify labels: rollup
| @@ -30,10 +30,11 @@ permissions: | |||
| defaults: | |||
| run: | |||
| shell: bash | |||
| concurrency: | |||
| group: "${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}" | |||
There was a problem hiding this comment.
Does this cancel parallel try builds? Right now we allow infinite concurrent try builds, and IMO we should continue to do so.
There was a problem hiding this comment.
Already discussed here. I hope it shouldn't cancel try builds, because they should have different SHAs.
There was a problem hiding this comment.
github.ref is not the commit SHA, it's refs/heads/trying.
There was a problem hiding this comment.
Then that's bad, I will investigate and fix. Thank you!
There was a problem hiding this comment.
Yeah it cancels parallel try builds, dammit. Sorry for that, I will send a PR with a fix soon.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2023
…lbini CI: do not cancel concurrent builds on the same branch Do not cancel concurrent builds on the same branch (outside of PRs). Instead, only cancel them if the builds have the same commit SHA. From the [documentation](https://docs.github.com/en/actions/learn-github-actions/contexts#github-context): > The commit SHA that triggered the workflow. The value of this commit SHA depends on the event that triggered the workflow. For more information, see "[Events that trigger workflows](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows)." For example, ffac537e6cbbf934b08745a378932722df287a53. Fixes: rust-lang#112955 (comment) r? `@pietroalbini`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jul 2, 2023
CI: do not cancel concurrent builds on the same branch Do not cancel concurrent builds on the same branch (outside of PRs). Instead, only cancel them if the builds have the same commit SHA. From the [documentation](https://docs.github.com/en/actions/learn-github-actions/contexts#github-context): > The commit SHA that triggered the workflow. The value of this commit SHA depends on the event that triggered the workflow. For more information, see "[Events that trigger workflows](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows)." For example, ffac537e6cbbf934b08745a378932722df287a53. Fixes: rust-lang/rust#112955 (comment) r? `@pietroalbini`
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Mar 14, 2024
CI: replace `cancel-outdated-builds` with `concurrency` group This is the last remaining [usage](https://github.com/search?q=org%3Arust-lang%20cancel-outdated-builds&type=code) of the [cancel-outdated-builds](https://github.com/rust-lang/simpleinfra/tree/master/github-actions/cancel-outdated-builds) CI action. Which means that if we remove its usage, we can remove the code of the action :) This action was replaced in `rust-lang/rust` with the native Github Actions `concurrency` group [last year](rust-lang/rust#112955). Note that unlike `rust-lang/rust`, which explicitly allows parallel try builds, `clippy` did not allow them, as all steps of the `clippy_bors.yaml` workflow used the `cancel-outdated-builds` action, regardless of the branch. So the new `concurrency` group mirrors that, which makes it a bit simpler than on `rust-lang/rust`. r? `@Mark-Simulacrum`
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Mar 14, 2024
CI: replace `cancel-outdated-builds` with `concurrency` group This is the last remaining [usage](https://github.com/search?q=org%3Arust-lang%20cancel-outdated-builds&type=code) of the [cancel-outdated-builds](https://github.com/rust-lang/simpleinfra/tree/master/github-actions/cancel-outdated-builds) CI action. Which means that if we remove its usage, we can remove the code of the action :) This action was replaced in `rust-lang/rust` with the native Github Actions `concurrency` group [last year](rust-lang/rust#112955). Note that unlike `rust-lang/rust`, which explicitly allows parallel try builds, `clippy` did not allow them, as all steps of the `clippy_bors.yaml` workflow used the `cancel-outdated-builds` action, regardless of the branch. So the new `concurrency` group mirrors that, which makes it a bit simpler than on `rust-lang/rust`. changelog: none r? `@Mark-Simulacrum`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
CI: do not cancel concurrent builds on the same branch Do not cancel concurrent builds on the same branch (outside of PRs). Instead, only cancel them if the builds have the same commit SHA. From the [documentation](https://docs.github.com/en/actions/learn-github-actions/contexts#github-context): > The commit SHA that triggered the workflow. The value of this commit SHA depends on the event that triggered the workflow. For more information, see "[Events that trigger workflows](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows)." For example, ffac537e6cbbf934b08745a378932722df287a53. Fixes: rust-lang/rust#112955 (comment) r? `@pietroalbini`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
CI: do not cancel concurrent builds on the same branch Do not cancel concurrent builds on the same branch (outside of PRs). Instead, only cancel them if the builds have the same commit SHA. From the [documentation](https://docs.github.com/en/actions/learn-github-actions/contexts#github-context): > The commit SHA that triggered the workflow. The value of this commit SHA depends on the event that triggered the workflow. For more information, see "[Events that trigger workflows](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows)." For example, ffac537e6cbbf934b08745a378932722df287a53. Fixes: rust-lang/rust#112955 (comment) r? `@pietroalbini`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with the
concurrencyattribute.r? @Mark-Simulacrum