Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests impl via obj unless denied #113020

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Add tests impl via obj unless denied #113020

merged 1 commit into from
Jun 28, 2023

Conversation

AnthonyKalaitzis
Copy link
Contributor

@AnthonyKalaitzis AnthonyKalaitzis commented Jun 25, 2023 •
edited by compiler-errors

Fixes #112737

Add simple tests to check feature change in #112320 is performing as expected.

Note:

  • Unsure about filenames, locations & function signature names (tried to make them something sensible)

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2023
bjorn3
bjorn3 reviewed Jun 25, 2023
View reviewed changes
tests/ui/traits/ice-with-dyn-pointee-errors.rs
@@ -0,0 +1,14 @@
#![feature(ptr_metadata)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please either reference #112737 in a comment or change the filename to issue-112737.rs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather the issue referenced in a comment

@compiler-errors
Copy link
Member

Please use a rebase to remove the merge commit from this commit history.

@compiler-errors
Copy link
Member

@rustbot author

(see instructions above to mark this ready for review)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2023
@AnthonyKalaitzis AnthonyKalaitzis force-pushed the add-tests-impl-via-obj-unless-denied branch from dc72009 to 3d0040a Compare June 26, 2023 09:10
@AnthonyKalaitzis
Copy link
Contributor Author

Added comments and the merge commit should be gone now

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2023
@compiler-errors
Copy link
Member

compiler-errors commented Jun 26, 2023 •
edited

Sorry, should've also asked for you to squash this into one commit 😅

Do you mind doing that?

@AnthonyKalaitzis AnthonyKalaitzis force-pushed the add-tests-impl-via-obj-unless-denied branch from 15216ae to 09f0548 Compare June 27, 2023 08:23
@AnthonyKalaitzis
Copy link
Contributor Author

No stress, commits should be squashed to one now @compiler-errors. Let me know if there's anything else I missed :)

@Rageking8
Copy link
Contributor

From a cursory look, this PR should close the issue mentioned on top once merged, if so change the first line of your PR description to (so the issue will be automatically closed upon the PR's successful merge):

Fixes #112737

Thanks.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 27, 2023

📌 Commit 09f0548 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2023
@bors
Auto merge of rust-lang#113105 - matthiaskrgr:rollup-rci0uym, r=matth…
6b46c99 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#112207 (Add trustzone and virtualization target features for aarch32.)
 - rust-lang#112454 (Make compiletest aware of targets without dynamic linking)
 - rust-lang#112628 (Allow comparing `Box`es with different allocators)
 - rust-lang#112692 (Provide more context for `rustc +nightly -Zunstable-options` on stable)
 - rust-lang#112972 (Make `UnwindAction::Continue` explicit in MIR dump)
 - rust-lang#113020 (Add tests impl via obj unless denied)
 - rust-lang#113084 (Simplify some conditions)
 - rust-lang#113103 (Normalize types when applying uninhabited predicate.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db11b77 into rust-lang:master Jun 28, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

ICE with dyn Pointee
6 participants
@AnthonyKalaitzis @rustbot @compiler-errors @Rageking8 @bors @bjorn3