Rollup of 5 pull requests #113554

matthiaskrgr · 2023-07-10T21:08:49Z

Successful merges:

style-guide: Expand example of combinable expressions to include arrays #113386 (style-guide: Expand example of combinable expressions to include arrays)
Add even more GHA log groups #113514 (Add even more GHA log groups)
Reuse LLVMConstInBoundsGEP2 #113523 (Reuse LLVMConstInBoundsGEP2)
Dynamically size sigaltstk in rustc #113528 (Dynamically size sigaltstk in rustc)
Update books #113548 (Update books)

r? @ghost
@rustbot modify labels: rollup

Arrays are allowed as combinable expressions, but none of the examples show that.

This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them.

We don't actually need it and it's quite slow.

This avoids the following broken logging in CI: ``` {"book":"test-pass","reference":"test-pass","rustbook":"test-fail","rust-by-example":"test-pass","nomicon":"test-pass","embedded-book":"test-pass","edition-guide":"test-pass"}::group::Building bootstrap ```

This caught several places which weren't waiting until the command finished to drop the Group. I also took the liberty of calling `msg_sysroot_tool` from `run_cargo_test` to reduce code duplication and make errors like this less likely in the future.

- group rustdoc-js-std - group rust-installer/test.sh

We have had LLVM 14 as our minimum for a bit now.

rustc installs a signal stack that assumes that MINSIGSTKSZ is a constant, unchanging value. Newer hardware undermines that assumption greatly, with register files larger than MINSIGSTKZ. Properly handle this so that it is correct on all supported Linux versions with all CPUs.

…e-expressions, r=compiler-errors style-guide: Expand example of combinable expressions to include arrays Arrays are allowed as combinable expressions, but none of the examples show that.

Add even more GHA log groups This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them. r? ``@oli-obk``

…s-gep2, r=cuviper Reuse LLVMConstInBoundsGEP2 We have had LLVM 14 as our minimum for a bit now.

…in-rustc-signal-handler, r=WaffleLapkin Dynamically size sigaltstk in rustc rustc installs a signal stack that assumes that MINSIGSTKSZ is a constant, unchanging value. Newer hardware undermines that assumption greatly, with register files larger than glibc's traditional static MINSIGSTKZ. Properly handle this so that it is correct on all supported Linux versions with all CPUs.

Update books ## rust-lang/book 1 commits in 21cf840842bdf768a798869f06373c96c1cc5122..668c64760b5c7ea654facb4ba5fe9faddfda27cc 2023-06-29 13:50:36 UTC to 2023-06-29 13:50:36 UTC - Remove adjective about what kind of number this is ## rust-lang/edition-guide 2 commits in f63e578b92ff43e8cc38fcaa257b660f45c8a8c2..2751bdcef125468ea2ee006c11992cd1405aebe5 2023-07-10 14:29:51 UTC to 2023-07-08 18:05:44 UTC - Update a link to a section in the cargo workspaces. (rust-lang/edition-guide#283) - b'...' byte strings -> byte chars (rust-lang/edition-guide#282) ## rust-embedded/book 2 commits in f2aed2fe8e9f55508c86ba3aa4b6789b18a08a22..1e5556dd1b864109985d5871616ae6b9164bcead 2023-06-29 07:34:47 UTC to 2023-06-27 23:43:06 UTC - add constgebra to list of math crates (rust-embedded/book#358) - Switch to GHMQ (rust-embedded/book#357) ## rust-lang/nomicon 1 commits in c369e4b489332f8721fbae630354fa83385d457d..302b995bcb24b70fd883980fd174738c3a10b705 2023-07-05 16:08:32 UTC to 2023-07-05 16:08:32 UTC - Minor improvements (rust-lang/nomicon#414) ## rust-lang/reference 5 commits in 5ca365eac678cb0d41a20b3204546d6ed70c7171..1ea0178266b3f3f613b0fabdaf16a83961c99cdb 2023-07-08 22:11:07 UTC to 2023-06-26 16:51:55 UTC - Remove doc of unstable feature of never type (rust-lang/reference#1376) - Typo: 'assingee' to 'assignee' in expressions.md (rust-lang/reference#1377) - str type: make sentence more readable (rust-lang/reference#1374) - Remove obsolete note about soundness hole in type-layout.md (rust-lang/reference#1367) - Typo: 'a' to 'an' in destructors.md (rust-lang/reference#1371) ## rust-lang/rust-by-example 1 commits in 57636d6926762861f34e030d52ca25a71e95e5bf..8a87926a985ce32ca1fad1be4008ee161a0b91eb 2023-07-07 22:44:06 UTC to 2023-07-07 22:44:06 UTC - Hint for RGB color calculation (rust-lang/rust-by-example#1726) ## rust-lang/rustc-dev-guide 18 commits in 17fe3e948498c50e208047a750f17d6a8d89669b..b5a12d95e32ae53791cc6ab44417774667ed2ac6 2023-07-09 14:50:50 UTC to 2023-06-28 04:55:24 UTC - fix: update link to function coverage (rust-lang/rustc-dev-guide#1727) - Fix a bug in getting-started.md (rust-lang/rustc-dev-guide#1726) - improve explanation of placing tests in separate file (rust-lang/rustc-dev-guide#1721) - various fixes/improvements to Contributing chapter (rust-lang/rustc-dev-guide#1723) - ty::ConstKind has moved (rust-lang/rustc-dev-guide#1724) - document `./x test --rustc-args` option (rust-lang/rustc-dev-guide#1719) - tests/run-make files have moved (rust-lang/rustc-dev-guide#1716) - replace dead link (rust-lang/rustc-dev-guide#1717) - fix link (rust-lang/rustc-dev-guide#1718) - update link (rust-lang/rustc-dev-guide#1709) - typo (rust-lang/rustc-dev-guide#1706) - OwningRef exists no more (rust-lang/rustc-dev-guide#1715) - Try to avoid confusion (rust-lang/rustc-dev-guide#1713) - Issue1707 doc simply use x (rust-lang/rustc-dev-guide#1710) - include rustc-dev-guide's own issues in suggested search (rust-lang/rustc-dev-guide#1708) - Improve feature gate and x.py docs (rust-lang/rustc-dev-guide#1701) - Fix some links (rust-lang/rustc-dev-guide#1705) - Define more lint terms. (rust-lang/rustc-dev-guide#1681)

matthiaskrgr · 2023-07-10T21:09:12Z

@bors r+ rollup=never p=5

bors · 2023-07-10T21:09:14Z

📌 Commit 76aa0d2 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-07-10T21:19:50Z

⌛ Testing commit 76aa0d2 with merge 41ed21d1cc4f074ce18cd90ba3e8a037df3b8b64...

rust-log-analyzer · 2023-07-10T21:37:44Z

The job dist-aarch64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

extracting /checkout/obj/build/cache/2023-05-30/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
downloading https://static.rust-lang.org/dist/2023-05-30/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/2023-05-30/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt
Build completed successfully in 0:00:36
##[group]Display CPU and Memory information
vendor_id : AuthenticAMD
cpu family : 25
model  : 1
model name : AMD EPYC 7763 64-Core Processor
---
[TIMING] doc::RustbookSrc<bootstrap::doc::TheBook> { target: aarch64-unknown-linux-gnu, name: "book/2018-edition", src: "/checkout/src/doc/book/2018-edition", parent: None } -- 0.166
[TIMING] doc::SharedAssets { target: aarch64-unknown-linux-gnu } -- 0.000
##[group]Documenting stage2 book redirect pages (x86_64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
##[group]Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
thread 'main' panicked at 'nested groups are not supported by GHA!', /checkout/src/tools/build_helper/src/ci.rs:53:9
##[endgroup]
Build completed unsuccessfully in 0:14:48
##[group]Clock drift check
  local time: Mon Jul 10 21:37:29 UTC 2023

bors · 2023-07-10T21:38:32Z

💔 Test failed - checks-actions

joshtriplett and others added 19 commits July 5, 2023 15:56

style-guide: Expand example of combinable expressions to include arrays

ddd5fd1

Arrays are allowed as combinable expressions, but none of the examples show that.

Add even more GHA log groups

ea17415

This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them.

Don't nest GHA groups in check::Std

8010365

Don't checkout the LLVM submodule in x dist --dry-run

116223e

We don't actually need it and it's quite slow.

fix nested GHA groups (redux)

ec2d072

Add GHA log groups for tool tests

dd5797a

Add must_use to msg_ functions

611b086

This caught several places which weren't waiting until the command finished to drop the Group. I also took the liberty of calling `msg_sysroot_tool` from `run_cargo_test` to reduce code duplication and make errors like this less likely in the future.

don't print download progress in CI

301ef43

put configure behind a group

8153f5b

add a couple more groups

7064af0

- group rustdoc-js-std - group rust-installer/test.sh

Reuse LLVMConstInBoundsGEP2

0726c78

We have had LLVM 14 as our minimum for a bit now.

Update books

b706cf8

Rollup merge of rust-lang#113386 - joshtriplett:style-guide-combinabl…

685623d

…e-expressions, r=compiler-errors style-guide: Expand example of combinable expressions to include arrays Arrays are allowed as combinable expressions, but none of the examples show that.

Rollup merge of rust-lang#113514 - jyn514:more-gha-groups, r=oli-obk

58f26fe

Add even more GHA log groups This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them. r? ``@oli-obk``

Rollup merge of rust-lang#113523 - workingjubilee:reuse-const-inbound…

1abf5d3

…s-gep2, r=cuviper Reuse LLVMConstInBoundsGEP2 We have had LLVM 14 as our minimum for a bit now.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 10, 2023

matthiaskrgr mentioned this pull request Jul 10, 2023

Add even more GHA log groups #113514

Merged

matthiaskrgr closed this Jul 10, 2023

matthiaskrgr deleted the rollup-yk5gtnn branch March 16, 2024 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #113554

Rollup of 5 pull requests #113554

matthiaskrgr commented Jul 10, 2023

matthiaskrgr commented Jul 10, 2023

bors commented Jul 10, 2023

bors commented Jul 10, 2023

rust-log-analyzer commented Jul 10, 2023

bors commented Jul 10, 2023

Rollup of 5 pull requests #113554

Rollup of 5 pull requests #113554

Conversation

matthiaskrgr commented Jul 10, 2023

matthiaskrgr commented Jul 10, 2023

bors commented Jul 10, 2023

bors commented Jul 10, 2023

rust-log-analyzer commented Jul 10, 2023

bors commented Jul 10, 2023