don't replace opaque types under binders with infer vars

[aliemjay]

Fixes an ICE in the ui test code.

Fixes #109636
Fixes #109281
Fixes #86800

r? @oli-obk

[matthiaskrgr]

Does that fix any of these?
https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+%22escaping+bound+vars+in+predicate+Obligation%22

[aliemjay]

@matthiaskrgr good call, this should fix all these issues. I've hit this issue accidentally and was too lazy to search the issue tracker :)

[compiler-errors]

ui/generic-associated-types/issue-90014-tait2.rs is an interesting failure. Maybe we should only care if the escaping vars are actually captured by the opaque, and replace the others by something like 'static since they're bivariant lifetimes anyways?

[aliemjay]

ui/generic-associated-types/issue-90014-tait2.rs is fixed by #113690.

[oli-obk]

needs a rebase now that #113690 has landed

[oli-obk]

@bors r+

[bors]

📌 Commit 2e83a72 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2e83a72 with merge d6d9972777928945b047cc0dffa33475399045da...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d6d9972777928945b047cc0dffa33475399045da to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[matthiaskrgr]

@bors retry Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[bors]

⌛ Testing commit 2e83a72 with merge e595409...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e595409 to master...

[rust-timer]

Finished benchmarking commit (d6d9972777928945b047cc0dffa33475399045da): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.0%	[-4.9%, -2.0%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.0%	[-4.9%, -2.0%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.351s -> 650.741s (-0.09%)

[rust-timer]

Finished benchmarking commit (e595409): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.3%	[-5.4%, -3.4%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.3%	[-5.4%, -3.4%]	6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.428s -> 650.515s (0.01%)