Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle ternary operator #114028

Merged
merged 3 commits into from Jul 29, 2023
Merged

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jul 24, 2023

Fixes #112578

May not be the best way to do this as it doesn't check for a single :, so it could perhaps appear even when the actual issue is just a missing semicolon. May not be the biggest deal, though?

Nevermind, got it working properly now ^^

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2023
tests/ui/parser/ternary_operator.rs Outdated Show resolved Hide resolved
tests/ui/parser/ternary_operator.rs Outdated Show resolved Hide resolved
tests/ui/parser/ternary_operator.stderr Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

gotta do a perf run cause parser is larger

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 25, 2023
@bors
Copy link
Contributor

bors commented Jul 25, 2023

⌛ Trying commit faa7395 with merge bd6b819d60ffdfdba3010b39e4097b59d1aafb85...

@Centri3
Copy link
Member Author

Centri3 commented Jul 25, 2023

I actually just removed the maybe_ternary_lo field, so it should be the same size again. But yeah a perf run is wise

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 29, 2023

📌 Commit 79b6ed0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2023
@bors
Copy link
Contributor

bors commented Jul 29, 2023

⌛ Testing commit 79b6ed0 with merge a04e649...

@bors
Copy link
Contributor

bors commented Jul 29, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a04e649 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 29, 2023
@bors bors merged commit a04e649 into rust-lang:master Jul 29, 2023
12 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 29, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a04e649): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)
-1.6% [-3.5%, -0.7%] 19
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.6% [-3.5%, -0.7%] 19

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.386s -> 652.746s (0.21%)

@Centri3 Centri3 deleted the ternary-operator branch July 30, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-existant ternary operator is not gracefully handled
7 participants