Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark shallow_lint_levels_on as eval_always. #114536

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Aug 6, 2023

It does not need it. Removing it allows to skip recomputation.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2023
@cjgillot
Copy link
Contributor Author

cjgillot commented Aug 6, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 6, 2023
@bors
Copy link
Contributor

bors commented Aug 6, 2023

⌛ Trying commit 4e2a9b6 with merge 329d67175783742c7c1e66bded905399dce3384e...

@bors
Copy link
Contributor

bors commented Aug 6, 2023

☀️ Try build successful - checks-actions
Build commit: 329d67175783742c7c1e66bded905399dce3384e (329d67175783742c7c1e66bded905399dce3384e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (329d67175783742c7c1e66bded905399dce3384e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.5%, -1.0%] 9
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.2% [-1.5%, -1.0%] 9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-3.6%, -2.1%] 3
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.941s -> 651.125s (0.18%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 6, 2023
@cjgillot cjgillot marked this pull request as ready for review August 6, 2023 20:26
@cjgillot
Copy link
Contributor Author

cjgillot commented Aug 6, 2023

r? compiler

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Aug 16, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 16, 2023

📌 Commit 4e2a9b6 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2023
@compiler-errors
Copy link
Member

@bors rollup=never

@TaKO8Ki this PR has perf effects, I don't think it should be rolled up 😅

@bors
Copy link
Contributor

bors commented Aug 16, 2023

⌛ Testing commit 4e2a9b6 with merge 4e3ce0e...

@bors
Copy link
Contributor

bors commented Aug 16, 2023

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 4e3ce0e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2023
@bors bors merged commit 4e3ce0e into rust-lang:master Aug 16, 2023
12 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@cjgillot cjgillot deleted the eval-lint-levels branch August 16, 2023 06:41
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4e3ce0e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
-0.7% [-1.3%, -0.3%] 30
Improvements ✅
(secondary)
-0.5% [-1.0%, -0.3%] 15
All ❌✅ (primary) -0.7% [-1.3%, -0.3%] 30

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.8%, -0.8%] 7
Improvements ✅
(secondary)
-2.6% [-3.1%, -2.1%] 2
All ❌✅ (primary) -1.3% [-1.8%, -0.8%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.234s -> 634.526s (-0.27%)
Artifact size: 346.89 MiB -> 346.86 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants