Skip to content

[beta] Update LLVM to resolve a miscompilation found in 114312. #114726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2023
Merged

[beta] Update LLVM to resolve a miscompilation found in 114312. #114726

merged 2 commits into from
Aug 12, 2023

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Aug 11, 2023 •
edited
Loading

Related issue: #114312 .

After the master updates the LLVM, we will add the same test cases. In the meantime, close the issue.

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2023
@dianqk
Copy link
Member Author

dianqk commented Aug 11, 2023

@rustbot label: +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 11, 2023
cuviper
cuviper reviewed Aug 11, 2023
View reviewed changes
@cuviper
Copy link
Member

cuviper commented Aug 11, 2023

Thanks! We're outside normal procedure, but I'm accepting this backport based on #114312 (comment).
@rustbot label +beta-accepted -beta-nominated
@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

📌 Commit 8ca16b2ae5701afccfe51055a0425fb3fa6127de has been approved by cuviper

It is now in the queue for this repository.

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Aug 11, 2023
@bors bors added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2023
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 11, 2023
@scottmcm
Copy link
Member

@bors p=1 (bumping this above my PR since this is for beta, and mine isn't urgent)

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

⌛ Testing commit 8ca16b2ae5701afccfe51055a0425fb3fa6127de with merge a93a8865012b5e8ad54c266ecfd1c1472d63e1ba...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Aug 11, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2023
@dianqk
Copy link
Member Author

dianqk commented Aug 12, 2023

💔 Ooooooops!!
https://rust.godbolt.org/z/sfePo7bTb

I'm not sure why rustc didn't submit byval for aarch64. For this PR I would change it to only check on x86. Also, add a byval and readonly check.

@cuviper
Copy link
Member

cuviper commented Aug 12, 2023

I'm not sure why rustc didn't submit byval for aarch64.

I would assume that's just a difference in calling convention for their C ABIs.

@dianqk
Copy link
Member Author

dianqk commented Aug 12, 2023

I'm not sure why rustc didn't submit byval for aarch64.

I would assume that's just a difference in calling convention for their C ABIs.

Done. https://github.com/rust-lang/rust/compare/8ca16b2ae5701afccfe51055a0425fb3fa6127de..3008c3ee85223e69430e1e8712af4b683e33eb86. I hope this goes well.

@cuviper
Copy link
Member

cuviper commented Aug 12, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

📌 Commit 3008c3ee85223e69430e1e8712af4b683e33eb86 has been approved by cuviper

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 12, 2023
@bors
Copy link
Collaborator

bors commented Aug 12, 2023

⌛ Testing commit 3008c3ee85223e69430e1e8712af4b683e33eb86 with merge 2d143ad1542b85a8f00c01c820d5aad0c4fe2e89...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Aug 12, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 12, 2023
@dianqk
Copy link
Member Author

dianqk commented Aug 12, 2023

Change to only-x86_64-unknown-linux-gnu.

@cuviper
Copy link
Member

cuviper commented Aug 12, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

📌 Commit e241551 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2023
@bors
Copy link
Collaborator

bors commented Aug 12, 2023

⌛ Testing commit e241551 with merge 598a0a3...

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 598a0a3 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2023
@bors bors merged commit 598a0a3 into rust-lang:beta Aug 12, 2023
@rustbot rustbot added this to the 1.72.0 milestone Aug 12, 2023
@dianqk dianqk deleted the beta branch August 12, 2023 09:34
@cuviper cuviper mentioned this pull request Aug 14, 2023
Closed
@nikic nikic mentioned this pull request Aug 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2023
@bors
Auto merge of rust-lang#114847 - nikic:update-llvm-12, r=cuviper
2bc7929 
Update LLVM submodule

Merge the current release/17.x branch.

Fixes rust-lang#114691.
Fixes rust-lang#114312.

The test for the latter is taken from rust-lang#114726.
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees

@cuviper cuviper

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
7 participants
@dianqk @rustbot @cuviper @bors @scottmcm @rust-log-analyzer @workingjubilee