Skip to content

Fix bad suggestion when wrong parentheses around a dyn trait #114802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix bad suggestion when wrong parentheses around a dyn trait #114802

merged 1 commit into from
Aug 17, 2023

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Aug 14, 2023 •
edited
Loading

Fixes #114797

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2023
estebank
estebank reviewed Aug 14, 2023
View reviewed changes
@chenyukang chenyukang force-pushed the yukang-fix-114979-bad-parens-dyn branch 2 times, most recently from b4ea0f0 to 715bc34 Compare August 15, 2023 11:24
@chenyukang chenyukang force-pushed the yukang-fix-114979-bad-parens-dyn branch from 715bc34 to ddcd7ca Compare August 15, 2023 16:26
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

📌 Commit ddcd7ca has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2023
@bors
Copy link
Collaborator

bors commented Aug 17, 2023

⌛ Testing commit ddcd7ca with merge 0768872...

@bors bors mentioned this pull request Aug 17, 2023
Merged
@bors
Copy link
Collaborator

bors commented Aug 17, 2023

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 0768872 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2023
@bors bors merged commit 0768872 into rust-lang:master Aug 17, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 17, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0768872): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.726s -> 635.3s (-0.07%)
Artifact size: 347.09 MiB -> 347.04 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank approved these changes

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Diagnostics: bad suggestion when I have wrong parentheses around a dyn trait pointer type
6 participants
@chenyukang @rustbot @estebank @bors @rust-timer @compiler-errors