Remove assert that checks type equality #115215

ouz-a · 2023-08-25T15:03:07Z

#112307 although this prevented unsound issues it also seems to introduce regressions #114858 is example of this regression. I locally tested this #114858 (comment) issue and failing assert is this.

This is also related to #115025

rustbot · 2023-08-25T15:03:14Z

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-08-25T17:59:09Z

Ideally this would have a test. Is it impossible to minimize one from the example you linked?

ouz-a · 2023-08-25T18:58:33Z

Ideally this would have a test. Is it impossible to minimize one from the example you linked?

Spent some time trying to minimize it but, it's too interconnected. I didn't put a test for that reason, if we still need it I could add it.

compiler-errors · 2023-08-29T19:03:24Z

compiler/rustc_codegen_ssa/src/mir/locals.rs

-                }
-            }
-
+        for (_, value) in values.into_iter().enumerate() {


Can you modify this to a FIXME like below? And add a test from the issue that was recently minimized?

compiler-errors · 2023-08-30T01:52:02Z

@rustbot author

wesleywiser · 2023-08-31T14:38:08Z

Since #114858 is a stable-to-stable regression, should we consider backporting this to stable & beta once it is merged?

apiraino · 2023-09-07T10:34:03Z

I'll go ahead and nominate this patch for backports, I guess beta=1.73.0 and stable=1.72.1 (or 1.73.0 if we don't make it for the point release of Sept. 14th)

@rustbot label +beta-nominated +stable-nominated

lqd · 2023-09-07T12:25:17Z

The test was added so this looks ready to review.

@rustbot ready

lcnr · 2023-09-07T14:19:20Z

as a safer fix here, can you try to anonymize bound vars + erase regions with a FIXME to figure out why we have to erase regions here?

I think that should also fix the issue here while still preventing all actually harmful bugs

apiraino · 2023-09-07T14:25:17Z

Beta and stable backports provisionally accepted once merged, as per compiler team on Zulip.

@rustbot label +beta-accepted +stable-accepted

ouz-a · 2023-09-07T15:53:37Z

After discussing details of the issue with the @lcnr they suggested me to keep this as warn!, since underlying issue seems to be, these two types should be same after erasing their regions but even after erasing them, their upvars are different which shouldn't be.

compiler-errors · 2023-09-07T15:54:31Z

compiler/rustc_codegen_ssa/src/mir/locals.rs

+                    let local = mir::Local::from_usize(local);
+                    let expected_ty = self.monomorphize(self.mir.local_decls[local].ty);
+                    if expected_ty != op.layout.ty {
+                        warn!("Unexpected initial operand type.See the issues/114858");


Suggested change

warn!("Unexpected initial operand type.See the issues/114858");

warn!("Unexpected initial operand type. See the issues/114858");

compiler-errors · 2023-09-07T15:55:10Z

tests/ui/codegen/subtyping-enforces-type-equality.rs

@@ -1,5 +1,6 @@
-// run-pass
+// check-pass


maybe let's do build-pass? Does this not get triggered by this code -- I would expect a stderr file here.

lcnr · 2023-09-12T13:27:20Z

@bors r+ rollup

bors · 2023-09-12T13:27:22Z

📌 Commit 3ec0165 has been approved by lcnr

It is now in the queue for this repository.

bors · 2023-09-12T13:27:32Z

⌛ Testing commit 3ec0165 with merge e5fedce...

Mark-Simulacrum · 2023-09-12T14:35:53Z

@bors p=10

I'd like this landed quickly so we get testing on nightly prior to stable point release (currently aiming at 9/14).

bors · 2023-09-12T15:14:50Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing e5fedce to master...

rust-timer · 2023-09-12T20:33:15Z

Finished benchmarking commit (e5fedce): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[1.2%, 3.3%]	2
Regressions ❌ (secondary)	3.0%	[1.6%, 3.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[1.2%, 3.3%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.886s -> 632.565s (0.27%)
Artifact size: 317.92 MiB -> 317.90 MiB (-0.00%)

…Simulacrum [stable] 1.72.1 release This backports: * Remove assert that checks type equality rust-lang#115215 * implied bounds: do not ICE on unconstrained region vars rust-lang#115559 * rustdoc: correctly deal with self ty params when eliding default object lifetimes rust-lang#115276 * Stop emitting non-power-of-two vectors in (non-portable-SIMD) codegen rust-lang#115236 * Normalize before checking if local is freeze in deduced_param_attrs rust-lang#114948 Some cherry-picks required merge conflict resolution, we'll see if I got it right based on CI (rustdoc fix and LLVM codegen test). r? `@Mark-Simulacrum`

…k-Simulacrum [beta] backport This PR backports: - rust-lang#115785: Only suggest turbofish in patterns if we may recover - rust-lang#115527: Don't require `Drop` for `[PhantomData<T>; N]` where `N` and `T` are generic, if `T` requires `Drop` - rust-lang#115389: fix(resolve): update def if binding is warning ambiguity - rust-lang#115215: Remove assert that checks type equality r? `@Mark-Simulacrum`

> 1.72.1 resolves a few regressions introduced in 1.72.0: > - [Partially revert codegen change, improving codegen](rust-lang/rust#115236) > - [rustdoc: Fix self ty params in objects with lifetimes](rust-lang/rust#115276) > - [Fix regression in compile times](rust-lang/rust#114948) > - Resolve some ICEs in the compiler: > - [#115215](rust-lang/rust#115215) > - [#115559](rust-lang/rust#115559)

rustbot assigned compiler-errors Aug 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2023

lqd mentioned this pull request Aug 29, 2023

ICE: unexpected initial operand type. #114858

Open

compiler-errors reviewed Aug 29, 2023

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2023

ouz-a force-pushed the mir_issue branch from 390414e to 1a3a62c Compare August 30, 2023 07:52

ouz-a requested a review from compiler-errors August 30, 2023 07:52

rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Sep 7, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2023

rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Sep 7, 2023

compiler-errors reviewed Sep 7, 2023

View reviewed changes

ouz-a force-pushed the mir_issue branch 2 times, most recently from 79ed30f to 25cd191 Compare September 7, 2023 16:06

This comment has been minimized.

Sign in to view

fasterthanlime mentioned this pull request Sep 12, 2023

Upgrade to 2023-09-13 bearcove/fluke#107

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2023

Mark-Simulacrum removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Sep 12, 2023

Mark-Simulacrum mentioned this pull request Sep 12, 2023

[stable] 1.72.1 release #115787

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2023

bors merged commit e5fedce into rust-lang:master Sep 12, 2023
12 checks passed

rustbot added this to the 1.74.0 milestone Sep 12, 2023

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 16, 2023

Mark-Simulacrum modified the milestones: 1.74.0, 1.73.0 Sep 16, 2023

Mark-Simulacrum mentioned this pull request Sep 16, 2023

[beta] backport #115901

Merged

cuviper modified the milestones: 1.73.0, 1.72.1 Sep 19, 2023

mmastrac mentioned this pull request Sep 19, 2023

chore: bump Rust to 1.72.1 and cargo update denoland/deno#20572

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove assert that checks type equality #115215

Remove assert that checks type equality #115215

ouz-a commented Aug 25, 2023

rustbot commented Aug 25, 2023

compiler-errors commented Aug 25, 2023

ouz-a commented Aug 25, 2023

compiler-errors Aug 29, 2023

compiler-errors commented Aug 30, 2023

wesleywiser commented Aug 31, 2023

apiraino commented Sep 7, 2023

lqd commented Sep 7, 2023

lcnr commented Sep 7, 2023 •

edited

Loading

apiraino commented Sep 7, 2023

ouz-a commented Sep 7, 2023 •

edited

Loading

compiler-errors Sep 7, 2023

compiler-errors Sep 7, 2023

This comment has been minimized.

This comment has been minimized.

lcnr commented Sep 12, 2023

bors commented Sep 12, 2023

bors commented Sep 12, 2023

Mark-Simulacrum commented Sep 12, 2023

bors commented Sep 12, 2023

rust-timer commented Sep 12, 2023

	warn!("Unexpected initial operand type.See the issues/114858");
	warn!("Unexpected initial operand type. See the issues/114858");

Remove assert that checks type equality #115215

Remove assert that checks type equality #115215

Conversation

ouz-a commented Aug 25, 2023

rustbot commented Aug 25, 2023

compiler-errors commented Aug 25, 2023

ouz-a commented Aug 25, 2023

compiler-errors Aug 29, 2023

Choose a reason for hiding this comment

compiler-errors commented Aug 30, 2023

wesleywiser commented Aug 31, 2023

apiraino commented Sep 7, 2023

lqd commented Sep 7, 2023

lcnr commented Sep 7, 2023 • edited Loading

apiraino commented Sep 7, 2023

ouz-a commented Sep 7, 2023 • edited Loading

compiler-errors Sep 7, 2023

Choose a reason for hiding this comment

compiler-errors Sep 7, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

lcnr commented Sep 12, 2023

bors commented Sep 12, 2023

bors commented Sep 12, 2023

Mark-Simulacrum commented Sep 12, 2023

bors commented Sep 12, 2023

rust-timer commented Sep 12, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lcnr commented Sep 7, 2023 •

edited

Loading

ouz-a commented Sep 7, 2023 •

edited

Loading