Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Take::{fold, for_each} when wrapping TrustedRandomAccess iterators #115273

Merged
merged 3 commits into from Sep 2, 2023

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Aug 27, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 27, 2023
@the8472
Copy link
Member Author

the8472 commented Aug 27, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 27, 2023
@bors
Copy link
Contributor

bors commented Aug 27, 2023

⌛ Trying commit 72b01d5 with merge 7d5ad749fca60517ea8bcc653127f44338571f25...

@bors
Copy link
Contributor

bors commented Aug 27, 2023

☀️ Try build successful - checks-actions
Build commit: 7d5ad749fca60517ea8bcc653127f44338571f25 (7d5ad749fca60517ea8bcc653127f44338571f25)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7d5ad749fca60517ea8bcc653127f44338571f25): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-2.3% [-4.2%, -1.3%] 19
Improvements ✅
(secondary)
-3.2% [-4.3%, -2.1%] 2
All ❌✅ (primary) -2.3% [-4.2%, -1.3%] 19

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-5.6%, -0.9%] 18
Improvements ✅
(secondary)
-1.5% [-1.5%, -1.5%] 1
All ❌✅ (primary) -2.5% [-5.6%, -0.9%] 18

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.2%] 11
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.1%, -0.0%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-0.1%, 0.2%] 13

Bootstrap: 631.583s -> 630.336s (-0.20%)
Artifact size: 315.88 MiB -> 316.00 MiB (0.04%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2023
@cuviper
Copy link
Member

cuviper commented Sep 1, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit 07a1d5f has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@bors
Copy link
Contributor

bors commented Sep 1, 2023

⌛ Testing commit 07a1d5f with merge 81100a59d1bb866db62914253fb38b46d01880d3...

@bors
Copy link
Contributor

bors commented Sep 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023
@rust-log-analyzer

This comment has been minimized.

@the8472
Copy link
Member Author

the8472 commented Sep 2, 2023

seems like a transient issue

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Contributor

bors commented Sep 2, 2023

⌛ Testing commit 07a1d5f with merge 08403c4888652a3e67c2e0d921181cbe93dae630...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023
@the8472
Copy link
Member Author

the8472 commented Sep 2, 2023

limited the test to x86-64 since vectorization differs between platforms

@bors r=cuviper

@bors
Copy link
Contributor

bors commented Sep 2, 2023

📌 Commit f93e125 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Contributor

bors commented Sep 2, 2023

⌛ Testing commit f93e125 with merge c4f2577...

@bors
Copy link
Contributor

bors commented Sep 2, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing c4f2577 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2023
@bors bors merged commit c4f2577 into rust-lang:master Sep 2, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 2, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c4f2577): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [0.0%, 4.4%] 6
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 2
Improvements ✅
(primary)
-3.0% [-5.1%, -0.5%] 3
Improvements ✅
(secondary)
-4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) 0.4% [-5.1%, 4.4%] 9

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.1%] 14
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.0%, -0.0%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-0.0%, 0.1%] 16

Bootstrap: 629.877s -> 629.451s (-0.07%)
Artifact size: 316.63 MiB -> 316.50 MiB (-0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants