Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More precisely detect cycle errors from type_of on opaque #115294

Merged
merged 2 commits into from Aug 28, 2023
Merged

More precisely detect cycle errors from type_of on opaque #115294

merged 2 commits into from Aug 28, 2023

Conversation

compiler-errors
Copy link
Member

Not sure if this still needs work. Just putting it up for initial impressions, since it seems that a few people are frustrated with the increased error verbosity due to #113320.

Essentially we introduce a new sub-query for type_of specifically for opaques which returns a value that is able to distinguish "has errors" from "due to cycle recovery".

Fixes #115188

r? @oli-obk

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2023

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2023
@compiler-errors
Copy link
Member Author

Manually reassigning for when he gets back from vacation, I'm not in a rush 😝

@compiler-errors compiler-errors assigned oli-obk and unassigned TaKO8Ki Aug 27, 2023
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 27, 2023
@bors
Copy link
Contributor

bors commented Aug 27, 2023

⌛ Trying commit bf53598 with merge 9af0c3c23726cb4f505b9f46de5ecafd28fb5e63...

@bors
Copy link
Contributor

bors commented Aug 27, 2023

☀️ Try build successful - checks-actions
Build commit: 9af0c3c23726cb4f505b9f46de5ecafd28fb5e63 (9af0c3c23726cb4f505b9f46de5ecafd28fb5e63)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9af0c3c23726cb4f505b9f46de5ecafd28fb5e63): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 2.4% [1.2%, 4.2%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.4% [1.9%, 3.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.803s -> 631.901s (0.17%)
Artifact size: 316.08 MiB -> 316.20 MiB (0.04%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 28, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Aug 28, 2023

@bors r+ rollup

awesome!

@bors
Copy link
Contributor

bors commented Aug 28, 2023

📌 Commit bf53598 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 28, 2023
@bors
Auto merge of rust-lang#115326 - matthiaskrgr:rollup-qsoa8ar, r=matth…
4e78abb 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115164 (MIR validation: reject in-place argument/return for packed fields)
 - rust-lang#115240 (codegen_llvm/llvm_type: avoid matching on the Rust type)
 - rust-lang#115294 (More precisely detect cycle errors from type_of on opaque)
 - rust-lang#115310 (Document panic behavior across editions, and improve xrefs)
 - rust-lang#115311 (Revert "Suggest using `Arc` on `!Send`/`!Sync` types")
 - rust-lang#115317 (Devacationize oli-obk)
 - rust-lang#115319 (don't use SnapshotVec in Graph implementation, as it looks unused; use Vec instead)
 - rust-lang#115322 (Tweak output of `to_pretty_impl_header` involving only anon lifetimes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b4c63f0 into rust-lang:master Aug 28, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 28, 2023
@compiler-errors compiler-errors mentioned this pull request Aug 30, 2023
Closed
@compiler-errors compiler-errors deleted the cycle-err branch September 4, 2023 21:33
@kpreid kpreid mentioned this pull request Nov 7, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request Dec 7, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request Jan 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

Spurious "cannot check whether the hidden type of opaque type satisfies auto traits" errors
6 participants
@compiler-errors @rustbot @rust-timer @bors @oli-obk @TaKO8Ki