avoid stdout redirection on curl executions

[onur-ozkan]

Avoid redirecting the curl output directly to the stdout. This alteration affects the integrity of the file during the retry process, as it also redirects the logs from the retries. Consequently, this leads to the bootstrap process failing because of an invalid checksum.

For more information, see the zulip thread

Fixes #115275

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

Same problem here -

rust/src/bootstrap/download.rs

Line 240 in 61efe9d

curl.stdout(Stdio::from(f));

, right? Can you look into other curl downloads at least in bootstrap?

[onur-ozkan]

Same problem here -

rust/src/bootstrap/download.rs

Line 240 in 61efe9d

curl.stdout(Stdio::from(f));

, right? Can you look into other curl downloads at least in bootstrap?

This is already updated - I checked the whole rust source, only the parts I updated had this problem

[Mark-Simulacrum]

Oh somehow I missed that, sorry.

@bors r+ rollup

[bors]

📌 Commit 4ea90af has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4ea90af with merge 008c21c...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 008c21c to master...

[rust-timer]

Finished benchmarking commit (008c21c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.7%, -0.5%]	4
Improvements ✅ (secondary)	-2.9%	[-4.1%, -1.6%]	2
All ❌✅ (primary)	-0.6%	[-1.7%, 1.1%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.235s -> 631.413s (0.03%)
Artifact size: 316.59 MiB -> 316.57 MiB (-0.00%)