Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't record spans for predicates in coherence #115392

Merged
merged 1 commit into from Aug 31, 2023

Conversation

compiler-errors
Copy link
Member

Should improve perf (#115107 (comment)) for #114023 (comment)

r? aliemjay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2023
@aliemjay
Copy link
Member

r=me if it regains perf

@aliemjay
Copy link
Member

aliemjay commented Aug 31, 2023

or
@bors r+
i think the pevious run is enough

@compiler-errors
Copy link
Member Author

@bors r=aliemjay

@bors
Copy link
Contributor

bors commented Aug 31, 2023

📌 Commit 4647aea has been approved by aliemjay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2023
@compiler-errors
Copy link
Member Author

@bors rollup=never

@bors
Copy link
Contributor

bors commented Aug 31, 2023

⌛ Testing commit 4647aea with merge e51c5ea...

@bors
Copy link
Contributor

bors commented Aug 31, 2023

☀️ Test successful - checks-actions
Approved by: aliemjay
Pushing e51c5ea to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2023
@bors bors merged commit e51c5ea into rust-lang:master Aug 31, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 31, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e51c5ea): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-2.5%, -0.3%] 18
Improvements ✅
(secondary)
-0.8% [-1.0%, -0.2%] 8
All ❌✅ (primary) -1.1% [-2.5%, -0.3%] 18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [3.8%, 3.8%] 1
Improvements ✅
(primary)
-1.2% [-1.9%, -0.6%] 5
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.2% [-1.9%, -0.6%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.3% [-5.1%, -2.3%] 7
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.3% [-5.1%, -2.3%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.655s -> 631.235s (-0.07%)
Artifact size: 316.64 MiB -> 316.59 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants