Make termcolor types public in rustc_errors
#115393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After rust-lang#114104, `rust-gpu` is unable to create a custom `Emitter` as the bounds have changed to include `WriteColor`. I was able to work around this by adding `termcolor` as a direct dependency, but I believe this should be exposed as part of `rustc_errors` proper. See rust-lang#102992 for why `rust-gpu` needs to create a custom emitter.
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @oli-obk since you added this |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
This need comment over |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#115373 (Fix bors missing a commit when merging rust-lang#115355) - rust-lang#115378 (`ignore-cross-compile` remaining tests that run binaries) - rust-lang#115393 (Make `termcolor` types public in `rustc_errors`) r? `@ghost` `@rustbot` modify labels: rollup
LegNeato
added a commit
to LegNeato/rust
that referenced
this pull request
Sep 1, 2023
As suggested in rust-lang#115393, add a comment so someone doesn't clean these up.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 1, 2023
Add comment so pub items are not removed As suggested in rust-lang#115393, add a comment so someone doesn't clean these up.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Sep 2, 2023
Add comment so pub items are not removed As suggested in rust-lang/rust#115393, add a comment so someone doesn't clean these up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #114104,
rust-gpuis unable to create a customEmitteras the bounds have changed to includeWriteColor.I was able to work around this by adding
termcoloras a direct dependency, but I believe this should be exposed as part ofrustc_errorsproper.See #102992 for why
rust-gpuneeds to create a custom emitter.