Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(std): Stabilize 'os_str_bytes' feature #115443

Merged
merged 2 commits into from Sep 2, 2023
Merged

feat(std): Stabilize 'os_str_bytes' feature #115443

merged 2 commits into from Sep 2, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented Sep 1, 2023

Closes #111544

@epage
Copy link
Contributor Author

epage commented Sep 1, 2023

@rustbot modify labels: +T-libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 1, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 1, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Sep 1, 2023

The Miri subtree was changed

cc @rust-lang/miri

@cuviper
Copy link
Member

cuviper commented Sep 1, 2023

The FCP approval asked for a name change: #111544 (comment)

@epage
Copy link
Contributor Author

epage commented Sep 2, 2023

Thanks, somehow I missed that

@epage epage marked this pull request as draft September 2, 2023 00:05
@rustbot rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows labels Sep 2, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@epage epage marked this pull request as ready for review September 2, 2023 01:32
@epage
Copy link
Contributor Author

epage commented Sep 2, 2023

@rustbot ready

@cuviper
Copy link
Member

cuviper commented Sep 2, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 2, 2023

📌 Commit 30292bb has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
fmease added a commit to fmease/rust that referenced this pull request Sep 2, 2023
@fmease
Rollup merge of rust-lang#115443 - epage:os_str, r=cuviper
333684d 
feat(std): Stabilize 'os_str_bytes' feature

Closes rust-lang#111544
@fmease fmease mentioned this pull request Sep 2, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 2, 2023
@bors
Auto merge of rust-lang#115469 - matthiaskrgr:rollup-25ybx39, r=matth…
ad8f601 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114349 (rustc_llvm: Link to `zlib` on dragonfly and solaris)
 - rust-lang#114845 (Add alignment to the NPO guarantee)
 - rust-lang#115427 (kmc-solid: Fix `is_interrupted`)
 - rust-lang#115443 (feat(std): Stabilize 'os_str_bytes' feature)
 - rust-lang#115444 (Create a SMIR visitor)
 - rust-lang#115449 (Const-stabilize `is_ascii`)
 - rust-lang#115456 (Add spastorino on vacation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43e1561 into rust-lang:master Sep 2, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 2, 2023
@epage epage deleted the os_str branch September 2, 2023 17:02
@epage epage mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for os_str_bytes
5 participants
@epage @rustbot @rust-log-analyzer @cuviper @bors