Skip to content

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2023
Merged

also skip musl checks when BOOTSTRAP_SKIP_TARGET_SANITY is set #115471

merged 1 commit into from
Sep 2, 2023
+13 −10

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 2, 2023

Currently I cannot test musl targets in Miri via x.py; this PR fixes that.

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2023

r? @onur-ozkan

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 2, 2023
@onur-ozkan
Copy link
Contributor

Will queue it up once the CI is green

@onur-ozkan
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

📌 Commit 9cae47e has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Collaborator

bors commented Sep 2, 2023

⌛ Testing commit 9cae47e with merge 1cabd455938f7d2a7ea85f2a824a4d04efb0704f...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[00:18] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:18] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:18] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:18] / 
---
[00:18] / 
[ERROR]  >>

[00:18] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[00:18] / 
[00:18] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[00:18] / 
[00:18] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[00:18] / 
[00:18] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[00:18] / 
[00:18] / 
[ERROR]  >> preferably, a fix.
[00:18] / 
[ERROR]  >>

[00:18] / 
---
[00:27] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:27] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:27] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:27] / 
---
[00:27] / 
[ERROR]  >>

[00:27] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[00:27] / 
[00:27] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[00:27] / 
[00:27] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[00:27] / 
[00:27] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[00:27] / 
[00:27] / 
[ERROR]  >> preferably, a fix.
[00:27] / 
[ERROR]  >>

[00:27] / 
---
[01:22] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:22] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:22] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:22] / 
---
[01:22] / 
[ERROR]  >>

[01:22] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[01:22] / 
[01:22] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[01:22] / 
[01:22] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[01:22] / 
[01:22] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[01:22] / 
[01:22] / 
[ERROR]  >> preferably, a fix.
[01:22] / 
[ERROR]  >>

[01:22] / 
---
[01:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:19] / 
---
[01:19] / 
[ERROR]  >>

[01:19] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[01:19] / 
[01:19] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[01:19] / 
[01:19] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[01:19] / 
[01:19] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[01:19] / 
[01:19] / 
[ERROR]  >> preferably, a fix.
[01:19] / 
[ERROR]  >>

[01:19] / 
---
[01:20] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:20] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:20] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:20] / 
---
[01:20] / 
[ERROR]  >>

[01:20] / 
[ERROR]  >> NOTE: Your configuration includes features marked EXPERIMENTAL.
[01:20] / 
[01:20] / 
[ERROR]  >> Before submitting a bug report, try to reproduce it without enabling
[01:20] / 
[01:20] / 
[ERROR]  >> any experimental features. Otherwise, you'll need to debug it
[01:20] / 
[01:20] / 
[ERROR]  >> and present an explanation why it is a bug in crosstool-NG - or
[01:20] / 
[01:20] / 
[ERROR]  >> preferably, a fix.
[01:20] / 
[ERROR]  >>

[01:20] /

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2023

@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@bors
Copy link
Collaborator

bors commented Sep 2, 2023

⌛ Testing commit 9cae47e with merge bd7ee1d72149a4f9a41d0dc1e0fbf25bbf0ea14b...

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[00:20] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:20] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:20] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:20] / 
---
[00:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:19] / 
---
[01:16] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:16] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:16] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:16] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] /

@RalfJung
Copy link
Member Author

RalfJung commented Sep 2, 2023

@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023
@Mark-Simulacrum
Copy link
Member

@bors p=105

Trying to see if this works now...

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

⌛ Testing commit 9cae47e with merge 9f5fc1b...

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 9f5fc1b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2023
@bors bors merged commit 9f5fc1b into rust-lang:master Sep 2, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 2, 2023
@Mark-Simulacrum
Copy link
Member

@bors treeclosed-

@RalfJung RalfJung deleted the skipping-sanity branch September 3, 2023 07:38
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9f5fc1b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [1.2%, 4.9%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) 3.1% [1.2%, 4.9%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.451s -> 630.462s (0.16%)
Artifact size: 316.50 MiB -> 316.63 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@onur-ozkan onur-ozkan

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @onur-ozkan @bors @rust-log-analyzer @Mark-Simulacrum @rust-timer