Update mailmap #115702
Merged
Update mailmap #115702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
|
For the purposes of rust-lang/thanks#58, I think it would be better if there were something differentiating different people. So "ghost1" for the email, for example. This avoids merging people that aren't actually the same person. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 11, 2023
…oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 11, 2023
…oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#115335 (fix overflow in array length computation) - rust-lang#115440 (bootstrap/format: remove unnecessary paths.push) - rust-lang#115702 (Update mailmap) - rust-lang#115734 (Use no_core for KCFI tests to exercise them in CI) - rust-lang#115739 (Call `LateLintPass::check_attribute` from `with_lint_attrs`) - rust-lang#115743 (Point out if a local trait has no implementations) - rust-lang#115744 (Improve diagnostic for generic params from outer items (E0401)) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#115308 (suggest iter_mut() where trying to modify elements from .iter()) - rust-lang#115595 (Fix incorrect mutable suggestion information for binding in ref pattern like: `let &b = a;` ) - rust-lang#115702 (Update mailmap) - rust-lang#115708 (fix homogeneous_aggregate not ignoring some ZST) - rust-lang#115739 (Call `LateLintPass::check_attribute` from `with_lint_attrs`) - rust-lang#115743 (Point out if a local trait has no implementations) - rust-lang#115744 (Improve diagnostic for generic params from outer items (E0401)) r? `@ghost` `@rustbot` modify labels: rollup
|
@oli-obk The reason I say that is because it would affect rankings and whatnot. |
|
We could stop showing |
|
I initially considered that, but that as well is objectively incorrect. There is a person associated with it; they just don't want their name shown any more. |
|
hmm... I did not consider that. I don't know what the right thing to do here is, but I also personally don't like the rankings anyway, so I should not really be part of the discussion of details. For now it doesn't matter as we only have a single Ghost entry. We can start coming up with a new policy or just start numbering them as they come. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115335 (fix overflow in array length computation) - rust-lang#115440 (bootstrap/format: remove unnecessary paths.push) - rust-lang#115702 (Update mailmap) - rust-lang#115727 (Implement fallback for effect param) - rust-lang#115739 (Call `LateLintPass::check_attribute` from `with_lint_attrs`) - rust-lang#115743 (Point out if a local trait has no implementations) - rust-lang#115744 (Improve diagnostic for generic params from outer items (E0401)) - rust-lang#115752 (rustdoc: Add missing "Aliased type" title in the sidebar) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
Rollup merge of rust-lang#115702 - jonas-schievink:update-mailmap, r=oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/team#1071 / rust-lang/thanks#58