Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source type for invalid bool casts #115765

Merged
merged 1 commit into from Sep 12, 2023
Merged

Add source type for invalid bool casts #115765

merged 1 commit into from Sep 12, 2023

Conversation

asquared31415
Copy link
Contributor

Also adds tests for casting various types to bool that were otherwise untested.

r? @WaffleLapkin

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 11, 2023
@WaffleLapkin WaffleLapkin added the A-diagnostics Area: Messages for errors, warnings, and lints label Sep 11, 2023
@WaffleLapkin
Copy link
Member

r=me with green CI

@compiler-errors
Copy link
Member

@bors r=WaffleLapkin rollup

@bors
Copy link
Contributor

bors commented Sep 11, 2023

📌 Commit e36adff has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2023
@bors
Auto merge of rust-lang#115769 - matthiaskrgr:rollup-bo82nn9, r=matth…
6c03617 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#115687 (Add `i686-pc-windows-gnullvm` triple)
 - rust-lang#115765 (Add source type for invalid bool casts)
 - rust-lang#115768 (Remove spastorino as "on vacation")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32cf2c4 into rust-lang:master Sep 12, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 12, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2023
@rust-timer
Unrolled build for rust-lang#115765
43a8e2f 
Rollup merge of rust-lang#115765 - asquared31415:cast_diag, r=WaffleLapkin

Add source type for invalid bool casts

Also adds tests for casting various types to `bool` that were otherwise untested.

r? `@WaffleLapkin`
@asquared31415 asquared31415 deleted the cast_diag branch September 27, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asquared31415 @WaffleLapkin @compiler-errors @bors @rustbot