Fix duplicated crate keyword in suggested path #115876
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
GuillaumeGomez
force-pushed
the
fix-duplicated-crate-err
branch
from
ba9093a to
1ca042a
Compare
| pub mod utils { | ||
| pub fn f() { | ||
| let x = crate::linux::system::Y; | ||
| //~^ ERROR unresolved import |
There was a problem hiding this comment.
I didn't find a way to ensure that in the help message, we have the correct suggested path to prevent regressions from happening. If someone knows how I could do that, it'd be awesome!
There was a problem hiding this comment.
You could // run-rustfix which checks that the applied suggestion works
There was a problem hiding this comment.
Oh nice! Doing that right away. Thanks!
There was a problem hiding this comment.
Unfortunately it doesn't work because there are multiple suggestions:
thread '[ui] tests/ui/imports/issue-115858-duplicated-crate-diag.rs' panicked at src/tools/compiletest/src/runtest.rs:3830:17:
failed to apply suggestions for "/home/imperio/rust/rust/tests/ui/imports/issue-115858-duplicated-crate-diag.rs" with rustfix: Could not replace range 309...322 in file -- maybe parts of it were already replaced?
There was a problem hiding this comment.
Do you know maybe how to check this @estebank ?
There was a problem hiding this comment.
@GuillaumeGomez We should change the logic so that the last two suggestions aren't emitted if this one is. rustfix can't deal with multiple exclusive suggestions.
There was a problem hiding this comment.
You mean changing the logic behind the compiler error help messages or rustfix? In any case, what do you have in mind?
There was a problem hiding this comment.
The compiler is the one responsible to not emit unnecessary suggestions. I'd need to look at the code more closely to see how to signal that the more specific suggestion has already been added to the diagnostic, to not add the later ones.
|
r? estebank |
|
r? compiler |
oli-obk
added
S-waiting-on-author
|
@GuillaumeGomez @rustbot label: +S-inactive |
rustbot
added
the
S-inactive
Fixes #115858.
This only appears starting the 2018 edition because of this.