tests/ui: Split large_moves.rs and move to lint/large_assignments #116036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want the attribute for the attribute revision.
rustbot
added
S-waiting-on-review
14 tasks
Enselic
force-pushed
the
split-large_moves
branch
from
385c9e2
to
f7d6b77
Compare
To make failing tests easier to debug with --emit=mir, etc.
Enselic
force-pushed
the
split-large_moves
branch
from
f7d6b77
to
d016e9a
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#114379 (Command: also print removed env vars) - rust-lang#116034 (add UI test for delimiter errors) - rust-lang#116036 (tests/ui: Split large_moves.rs and move to lint/large_assignments) - rust-lang#116038 (Fall back to _SC_NPROCESSORS_ONLN if sched_getaffinity returns an empty mask) - rust-lang#116039 (Account for nested `impl Trait` in TAIT) - rust-lang#116041 (Add note to `is_known_rigid`) - rust-lang#116049 (give FutureIncompatibilityReason variants more explicit names) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
Rollup merge of rust-lang#116036 - Enselic:split-large_moves, r=oli-obk tests/ui: Split large_moves.rs and move to lint/large_assignments To make failing tests easier to debug with `--emit=mir`, etc. Don't bother with `revisions: attribute option` for both tests though. Seems sufficient to just have that on one of the tests. `git show -M --find-renames=40%` makes the diff easier to review. Or note that before this change we had one test with 4 errors, now we have 2 tests with 2 errors each. r? `@oli-obk` Part of rust-lang#83518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make failing tests easier to debug with
--emit=mir, etc.Don't bother with
revisions: attribute optionfor both tests though. Seems sufficient to just have that on one of the tests.git show -M --find-renames=40%makes the diff easier to review. Or note that before this change we had one test with 4 errors, now we have 2 tests with 2 errors each.r? @oli-obk
Part of #83518