Return multiple object-safety violation errors and code improvements to the object-safety check #116401

WaffleLapkin · 2023-10-03T21:23:56Z

See individual commits for more information. Split off of #114260, since it turned out that the main intent of that PR was wrong.

r? oli-obk

compiler-errors · 2023-10-03T21:32:31Z

compiler/rustc_trait_selection/src/traits/object_safety.rs

-    }
+    virtual_call_violation_for_method(tcx, trait_def_id, method)
+        .iter()
+        .all(|v| matches!(v, MethodViolationCode::WhereClauseReferencesSelf))


thanks for doing this, it's so much safer lol

oli-obk

r=me with nit and doc comment fixed

oli-obk · 2023-10-06T13:38:22Z

compiler/rustc_trait_selection/src/traits/object_safety.rs

-        None | Some(MethodViolationCode::WhereClauseReferencesSelf) => true,
-        Some(_) => false,
-    }
+    virtual_call_violation_for_method(tcx, trait_def_id, method)


nit: make violation plural in these functions

WaffleLapkin · 2023-10-25T20:59:48Z

@bors r=@oli-obk

bors · 2023-10-25T20:59:50Z

📌 Commit ecdbefa has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116401 (Return multiple object-safety violation errors and code improvements to the object-safety check) - rust-lang#116553 (Do not suggest 'Trait<Assoc=arg>' when in trait impl) - rust-lang#116931 (Improve the warning messages for the `#[diagnostic::on_unimplemented]`) - rust-lang#117008 (Uplift `Canonical` to `rustc_type_ir`) - rust-lang#117009 (On unresolved imports, suggest a disambiguated path if necessary to avoid collision with local items) - rust-lang#117175 (Rename AsyncCoroutineKind to CoroutineSource) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116401 - WaffleLapkin:vtablin''', r=oli-obk Return multiple object-safety violation errors and code improvements to the object-safety check See individual commits for more information. Split off of rust-lang#114260, since it turned out that the main intent of that PR was wrong. r? oli-obk

Make non-zero check more obvious

94c9d0c

rustbot assigned oli-obk Oct 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2023

compiler-errors reviewed Oct 3, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

oli-obk approved these changes Oct 6, 2023

View reviewed changes

oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2023

WaffleLapkin added 3 commits October 25, 2023 20:23

Add a comment explaining some weird is_vtable_safe_method behavior

6cb3376

Don't allow dead code

8958235

Return multiple object-safety violation errors

ecdbefa

rust-cloud-vms bot force-pushed the vtablin''' branch from cedc4e1 to ecdbefa Compare October 25, 2023 20:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2023

WaffleLapkin mentioned this pull request Oct 25, 2023

Don't show the same help multiple times for object safety violations #117186

Closed

matthiaskrgr mentioned this pull request Oct 25, 2023

Rollup of 6 pull requests #117193

Merged

bors merged commit d3fb29a into rust-lang:master Oct 26, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 26, 2023

WaffleLapkin deleted the vtablin''' branch October 26, 2023 09:05

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return multiple object-safety violation errors and code improvements to the object-safety check #116401

Return multiple object-safety violation errors and code improvements to the object-safety check #116401

WaffleLapkin commented Oct 3, 2023

compiler-errors Oct 3, 2023

This comment has been minimized.

oli-obk left a comment

oli-obk Oct 6, 2023

WaffleLapkin commented Oct 25, 2023

bors commented Oct 25, 2023

Return multiple object-safety violation errors and code improvements to the object-safety check #116401

Return multiple object-safety violation errors and code improvements to the object-safety check #116401

Conversation

WaffleLapkin commented Oct 3, 2023

compiler-errors Oct 3, 2023

Choose a reason for hiding this comment

This comment has been minimized.

oli-obk left a comment

Choose a reason for hiding this comment

oli-obk Oct 6, 2023

Choose a reason for hiding this comment

WaffleLapkin commented Oct 25, 2023

bors commented Oct 25, 2023