rustdoc: Use `ThinVec` in `GenericParamDefKind` #117337

camelid · 2023-10-29T05:46:00Z

This should hopefully reduce memory usage and improve performance since
these vectors are often empty (and GenericParamDefKind is constructed a lot).

rustbot · 2023-10-29T05:46:07Z

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

camelid · 2023-10-29T05:46:40Z

r? @GuillaumeGomez

@bors try @rust-timer queue

bors · 2023-10-29T05:47:49Z

⌛ Trying commit 0039153 with merge ecf3128...

…try> rustdoc: Use `ThinVec` in `GenericParamDefKind` This should hopefully reduce memory usage and improve performance since these vectors are often empty.

This should hopefully reduce memory usage and improve performance since these vectors are often empty (and `GenericParamDefKind` is constructed *a lot*).

camelid · 2023-10-29T06:15:38Z

Oof, forgot size checks aren't run on arm...

camelid · 2023-10-29T06:15:48Z

@bors try @rust-timer queue

bors · 2023-10-29T06:16:56Z

⌛ Trying commit 3784adc with merge c2a267c...

…try> rustdoc: Use `ThinVec` in `GenericParamDefKind` This should hopefully reduce memory usage and improve performance since these vectors are often empty (and `GenericParamDefKind` is constructed *a lot*).

bors · 2023-10-29T07:39:16Z

☀️ Try build successful - checks-actions
Build commit: c2a267c (c2a267ce3ff03a6b1fba8a47d82acaa437b5b6f6)

rust-timer · 2023-10-29T09:53:56Z

Finished benchmarking commit (c2a267c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-4.4%, -1.2%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.381s -> 636.608s (0.04%)
Artifact size: 304.39 MiB -> 304.41 MiB (0.01%)

GuillaumeGomez · 2023-10-29T11:32:42Z

No significant result apparently. Well, the type size still was decreased so let's merge it. Thanks!

@bors r+ rollup

bors · 2023-10-29T11:32:43Z

📌 Commit 3784adc has been approved by GuillaumeGomez

It is now in the queue for this repository.

…=GuillaumeGomez rustdoc: Use `ThinVec` in `GenericParamDefKind` This should hopefully reduce memory usage and improve performance since these vectors are often empty (and `GenericParamDefKind` is constructed *a lot*).

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#115968 (Don't use LFS64 symbols on musl) - rust-lang#117043 (add bootstrap flag `--skip-stage0-validation`) - rust-lang#117082 (Fix closure-inherit-target-feature test for SGX platform) - rust-lang#117312 (memcpy assumptions: link to source showing that GCC makes the same assumption) - rust-lang#117337 (rustdoc: Use `ThinVec` in `GenericParamDefKind`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117337 - camelid:genparamdefkind-thinvec, r=GuillaumeGomez rustdoc: Use `ThinVec` in `GenericParamDefKind` This should hopefully reduce memory usage and improve performance since these vectors are often empty (and `GenericParamDefKind` is constructed *a lot*).

rustbot assigned jsha Oct 29, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 29, 2023

This comment has been minimized.

Sign in to view

rustbot assigned GuillaumeGomez and unassigned jsha Oct 29, 2023

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 29, 2023

This comment has been minimized.

Sign in to view

rustdoc: Use ThinVec in GenericParamDefKind

3784adc

This should hopefully reduce memory usage and improve performance since these vectors are often empty (and `GenericParamDefKind` is constructed *a lot*).

camelid force-pushed the genparamdefkind-thinvec branch from 0039153 to 3784adc Compare October 29, 2023 06:15

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2023

This was referenced Oct 29, 2023

Rollup of 6 pull requests #117353

Closed

Rollup of 5 pull requests #117354

Merged

bors merged commit 8b461d0 into rust-lang:master Oct 29, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 29, 2023

camelid deleted the genparamdefkind-thinvec branch October 29, 2023 14:58

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: Use `ThinVec` in `GenericParamDefKind` #117337

rustdoc: Use `ThinVec` in `GenericParamDefKind` #117337

camelid commented Oct 29, 2023 •

edited

rustbot commented Oct 29, 2023

camelid commented Oct 29, 2023

This comment has been minimized.

bors commented Oct 29, 2023

This comment has been minimized.

camelid commented Oct 29, 2023

camelid commented Oct 29, 2023

This comment has been minimized.

bors commented Oct 29, 2023

bors commented Oct 29, 2023

This comment has been minimized.

rust-timer commented Oct 29, 2023

GuillaumeGomez commented Oct 29, 2023

bors commented Oct 29, 2023

rustdoc: Use ThinVec in GenericParamDefKind #117337

rustdoc: Use ThinVec in GenericParamDefKind #117337

Conversation

camelid commented Oct 29, 2023 • edited

rustbot commented Oct 29, 2023

camelid commented Oct 29, 2023

This comment has been minimized.

bors commented Oct 29, 2023

This comment has been minimized.

camelid commented Oct 29, 2023

camelid commented Oct 29, 2023

This comment has been minimized.

bors commented Oct 29, 2023

bors commented Oct 29, 2023

This comment has been minimized.

rust-timer commented Oct 29, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

GuillaumeGomez commented Oct 29, 2023

bors commented Oct 29, 2023

rustdoc: Use `ThinVec` in `GenericParamDefKind` #117337

rustdoc: Use `ThinVec` in `GenericParamDefKind` #117337

camelid commented Oct 29, 2023 •

edited