Implement rustc part of RFC 3127 trim-paths #115214

Urgau · 2023-08-25T14:52:00Z

This PR implements (or at least tries to) RFC 3127 trim-paths, the rustc part. That is -Zremap-path-scope with all of it's components/scopes.

@rustbot label: +F-trim-paths

rustbot · 2023-08-25T14:52:07Z

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-08-25T14:52:10Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

The Miri subtree was changed

cc @rust-lang/miri

rustbot · 2023-08-25T15:38:25Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

weihanglo · 2023-08-31T14:39:10Z

@Urgau have you started cargo part of this? I can help do that if you haven't.

Urgau · 2023-08-31T14:42:11Z

@Urgau have you started cargo part of this? I can help do that if you haven't.

No, I haven't and to be honest I'm not sure when or if I would have done it any time soon.

weihanglo · 2023-09-06T15:30:00Z

PR on cargo side rust-lang/cargo#12625

bors · 2023-09-08T12:02:34Z

☔ The latest upstream changes (presumably #113492) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-09-09T00:42:00Z

☔ The latest upstream changes (presumably #115685) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-09-12T01:50:48Z

☔ The latest upstream changes (presumably #115671) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-09-25T22:50:08Z

☔ The latest upstream changes (presumably #115704) made this pull request unmergeable. Please resolve the merge conflicts.

Urgau · 2023-09-26T17:25:38Z

@compiler-errors This PR is waiting on you (to review).
I will continue to rebase for the time being.

Let me know if you don't have time or prefer that another reviewer takes care of reviewing this PR.

compiler-errors · 2023-09-27T03:32:56Z

Sorry, I'll try to review this in a few days. If in a couple of days you still haven't heard anything, feel free to eithe bother me or re-roll the reviewer.

compiler-errors · 2023-10-02T16:09:33Z

@bors r+

bors · 2023-10-02T16:09:35Z

📌 Commit 5d10381 has been approved by compiler-errors

It is now in the queue for this repository.

MacOS (and all apple targets) have -Csplit-debuginfo=packed as default instead of "off" like all other targets (well there is Windows, but we don't test it in those tests), also -Csplit-debuginfo is not stable on all targets so we only set in on Darwin where is matters.

compiler-errors · 2023-10-19T17:00:42Z

@bors r+

bors · 2023-10-19T17:00:44Z

📌 Commit 5c41de1 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-10-19T19:09:32Z

⌛ Testing commit 5c41de1 with merge 94c4e5c...

bors · 2023-10-19T21:00:44Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 94c4e5c to master...

rust-timer · 2023-10-19T22:44:26Z

Finished benchmarking commit (94c4e5c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-4.8%	[-4.8%, -4.8%]	1
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	3

Bootstrap: 629.154s -> 627.8s (-0.22%)
Artifact size: 304.03 MiB -> 304.02 MiB (-0.00%)

…r-errors Implement rustc part of RFC 3127 trim-paths This PR implements (or at least tries to) [RFC 3127 trim-paths](rust-lang#111540), the rustc part. That is `-Zremap-path-scope` with all of it's components/scopes. `@rustbot` label: +F-trim-paths

Fix -Zremap-path-scope typo This fixes a documentation typo from rust-lang#115214 where `-Zremap-path-prefix=object` should be `-Zremap-path-scope=object`. `@rustbot` label: +F-trim-paths

Fix -Zremap-path-scope typo This fixes a documentation typo from rust-lang#115214 where `-Zremap-path-prefix=object` should be `-Zremap-path-scope=object`. ``@rustbot`` label: +F-trim-paths

Fix -Zremap-path-scope typo This fixes a documentation typo from rust-lang#115214 where `-Zremap-path-prefix=object` should be `-Zremap-path-scope=object`. ```@rustbot``` label: +F-trim-paths

Rollup merge of rust-lang#120225 - micolous:patch-1, r=michaelwoerister Fix -Zremap-path-scope typo This fixes a documentation typo from rust-lang#115214 where `-Zremap-path-prefix=object` should be `-Zremap-path-scope=object`. ```@rustbot``` label: +F-trim-paths

rustbot assigned compiler-errors Aug 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 25, 2023

rustbot added the F-trim-paths Feature: trim-paths label Aug 25, 2023

This comment has been minimized.

Sign in to view

Urgau force-pushed the rfc-3127-trim-paths branch 2 times, most recently from e0dfc35 to a8ba752 Compare August 25, 2023 15:00

This comment has been minimized.

Sign in to view

Urgau force-pushed the rfc-3127-trim-paths branch from a8ba752 to 60e22dc Compare August 25, 2023 15:38

weihanglo mentioned this pull request Sep 6, 2023

feat: implement RFC 3127 -Ztrim-paths rust-lang/cargo#12625

Merged

8 tasks

Urgau force-pushed the rfc-3127-trim-paths branch from 60e22dc to 4652464 Compare September 8, 2023 13:25

Urgau force-pushed the rfc-3127-trim-paths branch from 4652464 to c196537 Compare September 9, 2023 10:22

Urgau force-pushed the rfc-3127-trim-paths branch from c196537 to 5cf0767 Compare September 12, 2023 12:02

Urgau force-pushed the rfc-3127-trim-paths branch from 5cf0767 to 5d10381 Compare September 26, 2023 16:51

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2023

Urgau added 6 commits October 17, 2023 10:11

[RFC 3127 - Trim Paths]: Adjust tests for -Zremap-path-scope

ab92dc3

[RFC 3127 - Trim Paths]: Add test for -Zremap-path-scope=macro

60e2446

[RFC 3127 - Trim Paths]: Add test for -Zremap-path-scope=diagnostics

297827f

[RFC 3127 - Trim Paths]: Add documentation for -Zremap-path-scope

b236642

Test -Zremap-path-scope=split-debuginfo with -Csplit-debuginfo=packed

5c41de1

Urgau force-pushed the rfc-3127-trim-paths branch from 87ed797 to 5c41de1 Compare October 17, 2023 08:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2023

bors merged commit 94c4e5c into rust-lang:master Oct 19, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 19, 2023

This was referenced Oct 19, 2023

(DRAFT) Combined draft branch for coverage work #115428

Closed

Add -Z llvm_module_flag #116555

Merged

ehuss mentioned this pull request Oct 30, 2023

Tracking Issue for trim-paths RFC 3127 #111540

Open

9 tasks

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Urgau mentioned this pull request Jan 16, 2024

fix(trim-paths): trim SO and DW_AT_comp_dir symbols for root DI node #118518

Closed

micolous mentioned this pull request Jan 22, 2024

Fix -Zremap-path-scope typo #120225

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement rustc part of RFC 3127 trim-paths #115214

Implement rustc part of RFC 3127 trim-paths #115214

Urgau commented Aug 25, 2023

rustbot commented Aug 25, 2023

rustbot commented Aug 25, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 25, 2023

weihanglo commented Aug 31, 2023

Urgau commented Aug 31, 2023

weihanglo commented Sep 6, 2023

bors commented Sep 8, 2023

bors commented Sep 9, 2023

bors commented Sep 12, 2023

bors commented Sep 25, 2023

Urgau commented Sep 26, 2023 •

edited

Loading

compiler-errors commented Sep 27, 2023

compiler-errors commented Oct 2, 2023

bors commented Oct 2, 2023

compiler-errors commented Oct 19, 2023

bors commented Oct 19, 2023

bors commented Oct 19, 2023

bors commented Oct 19, 2023

rust-timer commented Oct 19, 2023

Implement rustc part of RFC 3127 trim-paths #115214

Implement rustc part of RFC 3127 trim-paths #115214

Conversation

Urgau commented Aug 25, 2023

rustbot commented Aug 25, 2023

rustbot commented Aug 25, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 25, 2023

weihanglo commented Aug 31, 2023

Urgau commented Aug 31, 2023

weihanglo commented Sep 6, 2023

bors commented Sep 8, 2023

bors commented Sep 9, 2023

bors commented Sep 12, 2023

bors commented Sep 25, 2023

Urgau commented Sep 26, 2023 • edited Loading

compiler-errors commented Sep 27, 2023

compiler-errors commented Oct 2, 2023

bors commented Oct 2, 2023

compiler-errors commented Oct 19, 2023

bors commented Oct 19, 2023

bors commented Oct 19, 2023

bors commented Oct 19, 2023

rust-timer commented Oct 19, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Urgau commented Sep 26, 2023 •

edited

Loading