Allows `#[diagnostic::on_unimplemented]` attributes to have multiple #117205

weiznich · 2023-10-26T06:24:32Z

notes

This commit extends the #[diagnostic::on_unimplemented] (and #[rustc_on_unimplemented]) attributes to allow multiple note options. This enables emitting multiple notes for custom error messages. For now I've opted to not change any of the existing usages of #[rustc_on_unimplemented] and just updated the relevant compile tests.

r? @compiler-errors

I'm happy to adjust any of the existing changed location to emit the old error message if that's desired.

compiler-errors · 2023-10-26T15:03:08Z

tests/ui/sync/mutexguard-sync.stderr

+   = note: if you want to do aliasing and mutation between multiple threads, use `std::sync::RwLock`
   = note: if you want to do aliasing and mutation between multiple threads, use `std::sync::RwLock` or `std::sync::atomic::AtomicI32` instead


Huh, can you adjust the standard library impls to deduplicate these?

I've pushed 3c7daf9 to address that.

notes This commit extends the `#[diagnostic::on_unimplemented]` (and `#[rustc_on_unimplemented]`) attributes to allow multiple `note` options. This enables emitting multiple notes for custom error messages. For now I've opted to not change any of the existing usages of `#[rustc_on_unimplemented]` and just updated the relevant compile tests.

compiler-errors · 2023-10-29T19:23:09Z

👍
@bors r+

bors · 2023-10-29T19:23:11Z

📌 Commit 160b179 has been approved by compiler-errors

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#117147 (Print variadic argument pattern in HIR pretty printer) - rust-lang#117177 (Use ImageDataType for allocation type) - rust-lang#117205 (Allows `#[diagnostic::on_unimplemented]` attributes to have multiple) - rust-lang#117350 (coverage: Replace manual debug indents with nested tracing spans in `counters`) - rust-lang#117365 (Stabilize inline asm usage with rustc_codegen_cranelift) - rust-lang#117371 (Ignore RPIT duplicated lifetimes in `opaque_types_defined_by`) - rust-lang#117382 (Fail typeck for illegal break-with-value) - rust-lang#117385 (deduce_param_attrs: explain a read-only case) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117205 - weiznich:multiple_notes_for_on_unimplemented, r=compiler-errors Allows `#[diagnostic::on_unimplemented]` attributes to have multiple notes This commit extends the `#[diagnostic::on_unimplemented]` (and `#[rustc_on_unimplemented]`) attributes to allow multiple `note` options. This enables emitting multiple notes for custom error messages. For now I've opted to not change any of the existing usages of `#[rustc_on_unimplemented]` and just updated the relevant compile tests. r? `@compiler-errors` I'm happy to adjust any of the existing changed location to emit the old error message if that's desired.

rustbot assigned compiler-errors Oct 26, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 26, 2023

compiler-errors reviewed Oct 26, 2023

View reviewed changes

weiznich force-pushed the multiple_notes_for_on_unimplemented branch from d89c914 to 3c7daf9 Compare October 27, 2023 09:50

This comment has been minimized.

Sign in to view

weiznich force-pushed the multiple_notes_for_on_unimplemented branch from 3c7daf9 to 160b179 Compare October 27, 2023 10:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2023

fmease mentioned this pull request Oct 30, 2023

Rollup of 8 pull requests #117387

Merged

bors merged commit 5eb76fa into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allows `#[diagnostic::on_unimplemented]` attributes to have multiple #117205

Allows `#[diagnostic::on_unimplemented]` attributes to have multiple #117205

weiznich commented Oct 26, 2023

compiler-errors Oct 26, 2023

weiznich Oct 27, 2023

This comment has been minimized.

compiler-errors commented Oct 29, 2023

bors commented Oct 29, 2023

		= note: if you want to do aliasing and mutation between multiple threads, use `std::sync::RwLock`
		= note: if you want to do aliasing and mutation between multiple threads, use `std::sync::RwLock` or `std::sync::atomic::AtomicI32` instead

Allows #[diagnostic::on_unimplemented] attributes to have multiple #117205

Allows #[diagnostic::on_unimplemented] attributes to have multiple #117205

Conversation

weiznich commented Oct 26, 2023

compiler-errors Oct 26, 2023

Choose a reason for hiding this comment

weiznich Oct 27, 2023

Choose a reason for hiding this comment

This comment has been minimized.

compiler-errors commented Oct 29, 2023

bors commented Oct 29, 2023

Allows `#[diagnostic::on_unimplemented]` attributes to have multiple #117205

Allows `#[diagnostic::on_unimplemented]` attributes to have multiple #117205