Make `ty::print::Printer` take `&mut self` instead of `self` #116859

Nilstrieb · 2023-10-17T19:48:50Z

This simplifies the code by removing all the self assignments and
makes the flow of data clearer - always into the printer.
Especially in v0 mangling, which already used &mut self in some
places, it gets a lot more uniform.

rustbot · 2023-10-17T19:49:00Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-18T17:40:49Z

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

bors · 2023-10-21T00:10:53Z

☔ The latest upstream changes (presumably #116958) made this pull request unmergeable. Please resolve the merge conflicts.

This simplifies the code by removing all the `self` assignments and makes the flow of data clearer - always into the printer. Especially in v0 mangling, which already used `&mut self` in some places, it gets a lot more uniform.

oli-obk · 2023-10-23T16:48:38Z

r? @oli-obk

@bors r+

bors · 2023-10-23T16:48:40Z

📌 Commit 5acf26b has been approved by oli-obk

It is now in the queue for this repository.

…rinters, r=oli-obk Make `ty::print::Printer` take `&mut self` instead of `self` based on rust-lang#116815 This simplifies the code by removing all the `self` assignments and makes the flow of data clearer - always into the printer. Especially in v0 mangling, which already used `&mut self` in some places, it gets a lot more uniform.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115796 (Generate aggregate constants in DataflowConstProp.) - rust-lang#116859 (Make `ty::print::Printer` take `&mut self` instead of `self`) - rust-lang#117046 (return unfixed len if pat has reported error) - rust-lang#117070 (rustdoc: wrap Type with Box instead of Generics) - rust-lang#117074 (Remove smir from triage and add me to stablemir) - rust-lang#117086 (Update .mailmap to promote my livename) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107159 (rand use getrandom for freebsd (available since 12.x)) - rust-lang#116859 (Make `ty::print::Printer` take `&mut self` instead of `self`) - rust-lang#117046 (return unfixed len if pat has reported error) - rust-lang#117070 (rustdoc: wrap Type with Box instead of Generics) - rust-lang#117074 (Remove smir from triage and add me to stablemir) - rust-lang#117086 (Update .mailmap to promote my livename) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116859 - Nilstrieb:more-more-funny-pretty-printers, r=oli-obk Make `ty::print::Printer` take `&mut self` instead of `self` based on rust-lang#116815 This simplifies the code by removing all the `self` assignments and makes the flow of data clearer - always into the printer. Especially in v0 mangling, which already used `&mut self` in some places, it gets a lot more uniform.

rustbot assigned davidtwco Oct 17, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2023

Nilstrieb added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2023

Nilstrieb force-pushed the more-more-funny-pretty-printers branch from e5d1156 to 06686c7 Compare October 18, 2023 17:40

Nilstrieb added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Oct 18, 2023

Make ty::print::Printer take &mut self instead of self

5acf26b

This simplifies the code by removing all the `self` assignments and makes the flow of data clearer - always into the printer. Especially in v0 mangling, which already used `&mut self` in some places, it gets a lot more uniform.

Nilstrieb force-pushed the more-more-funny-pretty-printers branch from 06686c7 to 5acf26b Compare October 21, 2023 09:33

rustbot assigned oli-obk and unassigned davidtwco Oct 23, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2023

matthiaskrgr mentioned this pull request Oct 23, 2023

Rollup of 7 pull requests #117096

Closed

matthiaskrgr mentioned this pull request Oct 23, 2023

Rollup of 6 pull requests #117098

Closed

matthiaskrgr mentioned this pull request Oct 23, 2023

Rollup of 6 pull requests #117103

Merged

bors merged commit 8af4a3f into rust-lang:master Oct 24, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 24, 2023

Nilstrieb deleted the more-more-funny-pretty-printers branch October 24, 2023 03:44

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `ty::print::Printer` take `&mut self` instead of `self` #116859

Make `ty::print::Printer` take `&mut self` instead of `self` #116859

Nilstrieb commented Oct 17, 2023

rustbot commented Oct 17, 2023

rustbot commented Oct 18, 2023

bors commented Oct 21, 2023

oli-obk commented Oct 23, 2023

bors commented Oct 23, 2023

Make ty::print::Printer take &mut self instead of self #116859

Make ty::print::Printer take &mut self instead of self #116859

Conversation

Nilstrieb commented Oct 17, 2023

rustbot commented Oct 17, 2023

rustbot commented Oct 18, 2023

bors commented Oct 21, 2023

oli-obk commented Oct 23, 2023

bors commented Oct 23, 2023

Make `ty::print::Printer` take `&mut self` instead of `self` #116859

Make `ty::print::Printer` take `&mut self` instead of `self` #116859