Add support for i586-unknown-netbsd as target. #117170

he32 · 2023-10-25T15:29:20Z

This restricts instructions to those offered by Pentium, to support e.g. AMD Geode.

There is already an entry for this target in the NetBSD platform support page at

src/doc/rustc/src/platform-support/netbsd.md

...so this should forestall its removal.

Additional fixes are needed for some vendored modules, this is the changes in the rust compiler core itself.

This restricts instructions to those offered by Pentium, to support e.g. AMD Geode. There is already an entry for this target in the NetBSD platform support page at src/doc/rustc/src/platform-support/netbsd.md ...so this should forestall its removal. Additional fixes are needed for some vendored modules, this is the changes in the rust compiler core itself.

rustbot · 2023-10-25T15:29:28Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-25T15:29:31Z

These commits modify compiler targets.
(See the Target Tier Policy.)

oli-obk · 2023-10-25T15:41:58Z

cc @jethrogb

compiler/rustc_llvm/build.rs

...explaining why we need -latomic (gcc & g++ built for i486, and LLVM insisting on use of 64-bit atomics).

rustbot · 2023-10-26T17:12:11Z

These commits modify compiler targets.
(See the Target Tier Policy.)

he32 · 2023-10-26T17:30:29Z

These commits modify compiler targets. (See the Target Tier Policy.)

Yep, this does.

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

I believe that would be me.

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

I believe the i586-unknown-netbsd triple is consistent with current form.

   Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.

I don't think this does.

  If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.

I beleive this is compliant.

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

This is using open source toools only.

   The target must not introduce license incompatibilities.

No new restrictions are introduced.

   Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0).

That's agreed & understood.

   The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements.

There are no new dependencies/features required.

   Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.

As previously said it's using open source tools only.

   "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

There are no such terms present.

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

I'm not the reviewer here.

   This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

Again I'm not the reviewer here.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.
The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Building is described in platform support doc, there is (perhaps in error...) already an entry for this target there. I admit to not having tried running the tests; and instead abuse rust itself as its own self-test ("it builds, ship it!"). Well, not entirely true, I verify among other things that firefox builds and runs. This action (adding this target) should forestall its scheduled removal from the target description, ref. the recent action to clean up those.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Understood.

   Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

Understood.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

I believe I didn't break any other target.

   In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

I think there are no such problems in this PR.

bjorn3 · 2023-10-26T17:45:55Z

Thanks!

@bors r+

bors · 2023-10-26T17:45:58Z

📌 Commit 391b472 has been approved by bjorn3

It is now in the queue for this repository.

Add support for i586-unknown-netbsd as target. This restricts instructions to those offered by Pentium, to support e.g. AMD Geode. There is already an entry for this target in the NetBSD platform support page at src/doc/rustc/src/platform-support/netbsd.md ...so this should forestall its removal. Additional fixes are needed for some vendored modules, this is the changes in the rust compiler core itself.

Rollup of 5 pull requests Successful merges: - rust-lang#116858 (Suggest assoc fn `new` when trying to build tuple struct with private fields) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117025 (Cleanup and improve `--check-cfg` implementation) - rust-lang#117170 (Add support for i586-unknown-netbsd as target.) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) r? `@ghost` `@rustbot` modify labels: rollup

TaKO8Ki · 2023-10-27T04:36:26Z

It seems that this pull request causes an error on CI. @bors r-

#117255 (comment)

This hopefully fixes the CI run after integration of this target.

he32 · 2023-10-27T07:27:05Z

It seems that this pull request causes an error on CI. @bors r-

#117255 (comment)

This appears to concern the formatting. I've pushed a commit which should fix the two flagged issues (sort of "use" content, and formatting).

bjorn3 · 2023-10-28T13:28:05Z

error: target i586-unknown-netbsd is missing from platform-support.md

I think you need to add it to the platform-support.md index.

he32 · 2023-10-28T13:31:20Z

> error: target `i586-unknown-netbsd` is missing from platform-support.md I think you need to add it to the platform-support.md index.

Yep, figured that out, and just did so; awaiting new build/check results.

src/doc/rustc/src/platform-support.md

bjorn3 · 2023-10-28T17:03:11Z

@bors r+

bors · 2023-10-28T17:03:14Z

📌 Commit f5fa36f has been approved by bjorn3

It is now in the queue for this repository.

Add support for i586-unknown-netbsd as target. This restricts instructions to those offered by Pentium, to support e.g. AMD Geode. There is already an entry for this target in the NetBSD platform support page at src/doc/rustc/src/platform-support/netbsd.md ...so this should forestall its removal. Additional fixes are needed for some vendored modules, this is the changes in the rust compiler core itself.

…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#115773 (tvOS simulator support on Apple Silicon for rustc) - rust-lang#117162 (Remove `cfg_match` from the prelude) - rust-lang#117170 (Add support for i586-unknown-netbsd as target.) - rust-lang#117259 (Declare rustc_target's dependency on object/macho) - rust-lang#117311 (-Zunpretty help: add missing possible values) - rust-lang#117316 (Mark constructor of `BinaryHeap` as const fn) - rust-lang#117319 (explain why we don't inline when target features differ) - rust-lang#117325 (Small ty::print cleanups) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#117170 (Add support for i586-unknown-netbsd as target.) - rust-lang#117259 (Declare rustc_target's dependency on object/macho) - rust-lang#117322 (change default output mode of `BootstrapCommand`) - rust-lang#117325 (Small ty::print cleanups) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117170 - he32:netbsd-i586, r=bjorn3 Add support for i586-unknown-netbsd as target. This restricts instructions to those offered by Pentium, to support e.g. AMD Geode. There is already an entry for this target in the NetBSD platform support page at src/doc/rustc/src/platform-support/netbsd.md ...so this should forestall its removal. Additional fixes are needed for some vendored modules, this is the changes in the rust compiler core itself.

RalfJung · 2023-11-02T19:37:51Z

src/doc/rustc/src/platform-support.md

@@ -152,6 +152,7 @@ target | std | notes
 `i586-pc-windows-msvc` | * | 32-bit Windows w/o SSE [^x86_32-floats-x87]
 `i586-unknown-linux-gnu` | ✓ | 32-bit Linux w/o SSE (kernel 3.2, glibc 2.17) [^x86_32-floats-x87]
 `i586-unknown-linux-musl` | ✓ | 32-bit Linux w/o SSE, MUSL [^x86_32-floats-x87]
+[`i586-unknown-netbsd`](platform-support/netbsd.md) |  ✓ | 32-bit x86, restricted to Pentium


Could you please add a footnote for the usual x86-32 float problem? See the other i686/i586 targets. Depending on whether this target has SSE or not, you need x86_32-floats-return-ABI or x86_32-floats-x87.

…trieb Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table It appears it was intended to be tier 3, but was accidentally added to tier 2. Based on inspecting the PR adding it the table rust-lang#117170 and the fact that it is not built in CI which is one of the tier 2 requirements. cc `@he32` r? `@Nilstrieb`

…trieb Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table It appears it was intended to be tier 3, but was accidentally added to tier 2. Based on inspecting the PR adding it the table rust-lang#117170 and the fact that it is not built in CI which is one of the tier 2 requirements. cc ``@he32`` r? ``@Nilstrieb``

…trieb Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table It appears it was intended to be tier 3, but was accidentally added to tier 2. Based on inspecting the PR adding it the table rust-lang#117170 and the fact that it is not built in CI which is one of the tier 2 requirements. cc ```@he32``` r? ```@Nilstrieb```

…trieb Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table It appears it was intended to be tier 3, but was accidentally added to tier 2. Based on inspecting the PR adding it the table rust-lang#117170 and the fact that it is not built in CI which is one of the tier 2 requirements. cc ````@he32```` r? ````@Nilstrieb````

Rollup merge of rust-lang#119588 - Nemo157:i586-netbsd-tier-3, r=Nilstrieb Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table It appears it was intended to be tier 3, but was accidentally added to tier 2. Based on inspecting the PR adding it the table rust-lang#117170 and the fact that it is not built in CI which is one of the tier 2 requirements. cc ````@he32```` r? ````@Nilstrieb````

Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table It appears it was intended to be tier 3, but was accidentally added to tier 2. Based on inspecting the PR adding it the table rust-lang/rust#117170 and the fact that it is not built in CI which is one of the tier 2 requirements. cc ````@he32```` r? ````@Nilstrieb````

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 16, in accordance with the upstream changes. * Mark that on NetBSD we now need >= 9.0, so 8.x is no longer supported. * On NetBSD/sparc64 10.x, we now need GCC 12 to build the embedded LLVM, which is version 17; apparently GCC 10.4 or 10.5 mis-compiles it, resulting in an illegal instruction fault during the build. Ref. rust-lang/rust#117231 Upstream changes: Version 1.75.0 (2023-12-28) ========================== - [Stabilize `async fn` and return-position `impl Trait` in traits.] (rust-lang/rust#115822) - [Allow function pointer signatures containing `&mut T` in `const` contexts.] (rust-lang/rust#116015) - [Match `usize`/`isize` exhaustively with half-open ranges.] (rust-lang/rust#116692) - [Guarantee that `char` has the same size and alignment as `u32`.] (rust-lang/rust#116894) - [Document that the null pointer has the 0 address.] (rust-lang/rust#116988) - [Allow partially moved values in `match`.] (rust-lang/rust#103208) - [Add notes about non-compliant FP behavior on 32bit x86 targets.] (rust-lang/rust#113053) - [Stabilize ratified RISC-V target features.] (rust-lang/rust#116485) Compiler -------- - [Rework negative coherence to properly consider impls that only partly overlap.] (rust-lang/rust#112875) - [Bump `COINDUCTIVE_OVERLAP_IN_COHERENCE` to deny, and warn in dependencies.] (rust-lang/rust#116493) - [Consider alias bounds when computing liveness in NLL.] (rust-lang/rust#116733) - [Add the V (vector) extension to the `riscv64-linux-android` target spec.] (rust-lang/rust#116618) - [Automatically enable cross-crate inlining for small functions] (rust-lang/rust#116505) - Add several new tier 3 targets: - [`csky-unknown-linux-gnuabiv2hf`] (rust-lang/rust#117049) - [`i586-unknown-netbsd`] (rust-lang/rust#117170) - [`mipsel-unknown-netbsd`] (rust-lang/rust#117356) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Override `Waker::clone_from` to avoid cloning `Waker`s unnecessarily.] (rust-lang/rust#96979) - [Implement `BufRead` for `VecDeque<u8>`.] (rust-lang/rust#110604) - [Implement `FusedIterator` for `DecodeUtf16` when the inner iterator does.] (rust-lang/rust#110729) - [Implement `Not, Bit{And,Or}{,Assign}` for IP addresses.] (rust-lang/rust#113747) - [Implement `Default` for `ExitCode`.] (rust-lang/rust#114589) - [Guarantee representation of None in NPO] (rust-lang/rust#115333) - [Document when atomic loads are guaranteed read-only.] (rust-lang/rust#115577) - [Broaden the consequences of recursive TLS initialization.] (rust-lang/rust#116172) - [Windows: Support sub-millisecond sleep.] (rust-lang/rust#116461) - [Fix generic bound of `str::SplitInclusive`'s `DoubleEndedIterator` impl] (rust-lang/rust#100806) - [Fix exit status / wait status on non-Unix `cfg(unix)` platforms.] (rust-lang/rust#115108) Stabilized APIs --------------- - [`Atomic*::from_ptr`] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicUsize.html#method.from_ptr) - [`FileTimes`] (https://doc.rust-lang.org/stable/std/fs/struct.FileTimes.html) - [`FileTimesExt`] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTimesExt.html) - [`File::set_modified`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.set_modified) - [`File::set_times`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.set_times) - [`IpAddr::to_canonical`] (https://doc.rust-lang.org/stable/core/net/enum.IpAddr.html#method.to_canonical) - [`Ipv6Addr::to_canonical`] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.to_canonical) - [`Option::as_slice`] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_slice) - [`Option::as_mut_slice`] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_mut_slice) - [`pointer::byte_add`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_add) - [`pointer::byte_offset`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_offset) - [`pointer::byte_offset_from`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_offset_from) - [`pointer::byte_sub`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_sub) - [`pointer::wrapping_byte_add`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_add) - [`pointer::wrapping_byte_offset`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_offset) - [`pointer::wrapping_byte_sub`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_sub) These APIs are now stable in const contexts: - [`Ipv6Addr::to_ipv4_mapped`] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.to_ipv4_mapped) - [`MaybeUninit::assume_init_read`] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.assume_init_read) - [`MaybeUninit::zeroed`] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.zeroed) - [`mem::discriminant`] (https://doc.rust-lang.org/stable/core/mem/fn.discriminant.html) - [`mem::zeroed`] (https://doc.rust-lang.org/stable/core/mem/fn.zeroed.html) Cargo ----- - [Add new packages to `[workspace.members]` automatically.] (rust-lang/cargo#12779) - [Allow version-less `Cargo.toml` manifests.] (rust-lang/cargo#12786) - [Make browser links out of HTML file paths.] (rust-lang/cargo#12889) Rustdoc ------- - [Accept less invalid Rust in rustdoc.] (rust-lang/rust#117450) - [Document lack of object safety on affected traits.] (rust-lang/rust#113241) - [Hide `#[repr(transparent)]` if it isn't part of the public ABI.] (rust-lang/rust#115439) - [Show enum discriminant if it is a C-like variant.] (rust-lang/rust#116142) Compatibility Notes ------------------- - [FreeBSD targets now require at least version 12.] (rust-lang/rust#114521) - [Formally demote tier 2 MIPS targets to tier 3.] (rust-lang/rust#115238) - [Make misalignment a hard error in `const` contexts.] (rust-lang/rust#115524) - [Fix detecting references to packed unsized fields.] (rust-lang/rust#115583) - [Remove support for compiler plugins.] (rust-lang/rust#116412)

rustbot assigned oli-obk Oct 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2023

This comment has been minimized.

Sign in to view

bjorn3 reviewed Oct 25, 2023

View reviewed changes

compiler/rustc_llvm/build.rs Outdated Show resolved Hide resolved

This was referenced Oct 26, 2023

Use cfg(target_has_atomic) instead of hard coding which targets support atomics crossbeam-rs/crossbeam#1033

Closed

Use cfg(target_has_atomic) instead of hard coding which targets support atomics zip-rs/zip-old#413

Closed

rustc_llvm/build.rs: improve comment for NetBSD/i386 targets

391b472

...explaining why we need -latomic (gcc & g++ built for i486, and LLVM insisting on use of 64-bit atomics).

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

TaKO8Ki mentioned this pull request Oct 27, 2023

Rollup of 5 pull requests #117255

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 27, 2023

i586_unknown_netbsd.rs: fix formatting.

893e726

This hopefully fixes the CI run after integration of this target.

This comment has been minimized.

Sign in to view

For i586/NetBSD: fix another formatting insistence.

0f04e2d

This comment has been minimized.

Sign in to view

i586-unknown-netbsd: add entry in platform-support.md.

d9ddad3

bjorn3 reviewed Oct 28, 2023

View reviewed changes

src/doc/rustc/src/platform-support.md Outdated Show resolved Hide resolved

i586-unknown-netbsd platform-support.md: fix typo.

f5fa36f

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2023

workingjubilee mentioned this pull request Oct 28, 2023

Rollup of 8 pull requests #117333

Closed

workingjubilee mentioned this pull request Oct 29, 2023

Rollup of 4 pull requests #117336

Merged

bors merged commit 78b04b5 into rust-lang:master Oct 29, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 29, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

RalfJung reviewed Nov 2, 2023

View reviewed changes

Nemo157 mentioned this pull request Jan 4, 2024

Move i586-unknown-netbsd from tier 2 to tier 3 platform support table #119588

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for i586-unknown-netbsd as target. #117170

Add support for i586-unknown-netbsd as target. #117170

he32 commented Oct 25, 2023

rustbot commented Oct 25, 2023

rustbot commented Oct 25, 2023

This comment has been minimized.

oli-obk commented Oct 25, 2023

rustbot commented Oct 26, 2023

This comment has been minimized.

he32 commented Oct 26, 2023

bjorn3 commented Oct 26, 2023

bors commented Oct 26, 2023

TaKO8Ki commented Oct 27, 2023

he32 commented Oct 27, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bjorn3 commented Oct 28, 2023

he32 commented Oct 28, 2023 via email

bjorn3 commented Oct 28, 2023

bors commented Oct 28, 2023

RalfJung Nov 2, 2023

Add support for i586-unknown-netbsd as target. #117170

Add support for i586-unknown-netbsd as target. #117170

Conversation

he32 commented Oct 25, 2023

rustbot commented Oct 25, 2023

rustbot commented Oct 25, 2023

This comment has been minimized.

oli-obk commented Oct 25, 2023

rustbot commented Oct 26, 2023

This comment has been minimized.

he32 commented Oct 26, 2023

bjorn3 commented Oct 26, 2023

bors commented Oct 26, 2023

TaKO8Ki commented Oct 27, 2023

he32 commented Oct 27, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bjorn3 commented Oct 28, 2023

he32 commented Oct 28, 2023 via email

bjorn3 commented Oct 28, 2023

bors commented Oct 28, 2023

RalfJung Nov 2, 2023

Choose a reason for hiding this comment