Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for #113381 #117190

Merged
merged 1 commit into from Nov 6, 2023
Merged

add test for #113381 #117190

merged 1 commit into from Nov 6, 2023

Conversation

matthiaskrgr
Copy link
Member

Fixes #113381

r? fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2023
fee1-dead
fee1-dead reviewed Oct 26, 2023
View reviewed changes
tests/ui/rfcs/rfc-2632-const-trait-impl/effects/const_closure-const_trait_imp-ice-113381.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? it should be const_trait_impl

@fee1-dead
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023
@matthiaskrgr
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2023
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 6, 2023

📌 Commit 384f738 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2023
@bors
Auto merge of rust-lang#117641 - matthiaskrgr:rollup-f9c12td, r=matth…
189d6c7 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#117190 (add test for rust-lang#113381)
 - rust-lang#117516 (add test for rust-lang#113375)
 - rust-lang#117631 (Documentation cleanup for core::error::Request.)
 - rust-lang#117637 (Check binders with bound vars for global bounds that don't hold)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1683df7 into rust-lang:master Nov 6, 2023
11 checks passed
@rustbot rustbot added this to the 1.75.0 milestone Nov 6, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2023
@rust-timer
Unrolled build for rust-lang#117190
30b0db3 
Rollup merge of rust-lang#117190 - matthiaskrgr:test_effects_113381, r=fee1-dead

add test for rust-lang#113381

Fixes rust-lang#113381

r? fee1-dead
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Nov 7, 2023
@bors-ferrocene @RalfJung
@estebank @SparrowLii @matthiaskrgr @gurry @compiler-errors @thomcc @klensy @jackh726 @bjorn3 @HKalbasi @bors @smarnach @lqd @Dajamante
Merge #89 #90
e8a60e5 
89: Automated pull from upstream `master` r=Dajamante a=github-actions[bot]


This PR pulls the following changes from the upstream repository:

* rust-lang/rust#117006
* rust-lang/rust#117511
* rust-lang/rust#117641
  * rust-lang/rust#117637
  * rust-lang/rust#117631
  * rust-lang/rust#117516
  * rust-lang/rust#117190
* rust-lang/rust#117292
* rust-lang/rust#117603
* rust-lang/rust#116988
* rust-lang/rust#117630
  * rust-lang/rust#117615
  * rust-lang/rust#117613
  * rust-lang/rust#117592
* rust-lang/rust#117578
* rust-lang/rust#117435
* rust-lang/rust#117607



90: bump serde and serde_derive r=tshepang a=Dajamante

Trying to get around the failure seen in #86 

Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: Esteban Küber <esteban@kuber.com.ar>
Co-authored-by: SparrowLii <liyuan179@huawei.com>
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Co-authored-by: Gurinder Singh <frederick.the.fool@gmail.com>
Co-authored-by: Michael Goulet <michael@errs.io>
Co-authored-by: Thom Chiovoloni <thom@shift.click>
Co-authored-by: klensy <klensy@users.noreply.github.com>
Co-authored-by: Jack Huey <31162821+jackh726@users.noreply.github.com>
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Co-authored-by: hkalbasi <hamidrezakalbasi@protonmail.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: Sven Marnach <sven@mozilla.com>
Co-authored-by: Rémy Rakic <remy.rakic+github@gmail.com>
Co-authored-by: aissata <aimaiga2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.

ice: effects: ConstContext::Maybe must have host effect param'
4 participants
@matthiaskrgr @fee1-dead @bors @rustbot