Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest dereferencing the LHS for binops such as &T == T #117893

Merged
merged 1 commit into from Nov 15, 2023

Conversation

sjwang05
Copy link
Contributor

Fixes #52544

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2023
@wesleywiser
Copy link
Member

Thanks @sjwang05!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 14, 2023

📌 Commit 614ddc9 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#116244 (Apply structured suggestion that allows test to work since 1.64)
 - rust-lang#117686 (Build pre-coroutine-transform coroutine body on error)
 - rust-lang#117834 (target_feature: make it more clear what that 'Option' means)
 - rust-lang#117893 (Suggest dereferencing the LHS for binops such as `&T == T`)
 - rust-lang#117911 (Fix some typos)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 52f3a6f into rust-lang:master Nov 15, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 15, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2023
Rollup merge of rust-lang#117893 - sjwang05:issue-52544-take-1, r=wesleywiser

Suggest dereferencing the LHS for binops such as `&T == T`

Fixes rust-lang#52544
@sjwang05 sjwang05 deleted the issue-52544-take-1 branch January 16, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider borrowing here: &0
4 participants