Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize ptr::addr_eq #117968

Merged
merged 1 commit into from Nov 26, 2023
Merged

Stabilize ptr::addr_eq #117968

merged 1 commit into from Nov 26, 2023

Conversation

Urgau
Copy link
Contributor

@Urgau Urgau commented Nov 16, 2023

This PR stabilize the ptr_addr_eq library feature, representing:

// core::ptr

pub fn addr_eq<T: ?Sized, U: ?Sized>(p: *const T, q: *const U) -> bool;

FCP has already started on the tracking issue and is waiting on the final period comment.

Note: stabilizing this feature is somewhat of requirement for a new T-lang lint, cf. #117758 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 16, 2023
@dtolnay dtolnay assigned dtolnay and unassigned cuviper Nov 25, 2023
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

FCP in the tracking issue has completed.

@dtolnay dtolnay linked an issue Nov 25, 2023 that may be closed by this pull request
4 tasks
@dtolnay
Copy link
Member

dtolnay commented Nov 25, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2023

📌 Commit 8d91d66 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
@compiler-errors
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117651 (coverage: Simplify building coverage expressions based on sums)
 - rust-lang#117968 (Stabilize `ptr::addr_eq`)
 - rust-lang#118158 (Reduce fluent boilerplate)
 - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups)
 - rust-lang#118288 (Use `is_{some,ok}_and` more in the compiler)
 - rust-lang#118289 (`is_{some,ok}_and` for rustdoc)
 - rust-lang#118290 (Don't ICE when encountering placeholders in implied bounds computation)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117651 (coverage: Simplify building coverage expressions based on sums)
 - rust-lang#117968 (Stabilize `ptr::addr_eq`)
 - rust-lang#118158 (Reduce fluent boilerplate)
 - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups)
 - rust-lang#118288 (Use `is_{some,ok}_and` more in the compiler)
 - rust-lang#118289 (`is_{some,ok}_and` for rustdoc)
 - rust-lang#118290 (Don't ICE when encountering placeholders in implied bounds computation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fcb9fcc into rust-lang:master Nov 26, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 26, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
Rollup merge of rust-lang#117968 - Urgau:stabilize-ptr-addr-eq, r=dtolnay

Stabilize `ptr::addr_eq`

This PR stabilize the `ptr_addr_eq` library feature, representing:

```rust
// core::ptr

pub fn addr_eq<T: ?Sized, U: ?Sized>(p: *const T, q: *const U) -> bool;
```

FCP has already started [on the tracking issue](rust-lang#116324 (comment)) and is waiting on the final period comment.

Note: stabilizing this feature is somewhat of requirement for a new T-lang lint, cf. rust-lang#117758 (comment).
@Urgau Urgau deleted the stabilize-ptr-addr-eq branch November 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for ptr::addr_eq
6 participants