Rollup of 7 pull requests #118434
Merged
Rollup of 7 pull requests #118434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was merged by accident in a previous PR.
By moving most of `ItemLowerer::lower_assoc_item` into it. This is similar to `LoweringContext::lower_foreign_item`.
…en_future}`. Also remove some unnecessary slicing.
…, r=estebank Dont suggest `!` for path in function call if it has generic args Fixes rust-lang#118335
…ld-cleanup-stdlib, r=m-ou-se Address unused tuple struct fields in the standard library
…compiler-errors `rustc_ast_lowering` cleanups Just some cleanups I found while looking through this code. r? `@spastorino`
…rors format_foreign.rs: unwrap return Option value for `fn position`, as it always returns Some Trivial cleanup. It will be nice to have way to run exhaustiveness analysis on similar cases to see dead code.
…p-for-shorthand, r=compiler-errors Fix the issue of suggesting unwrap/expect for shorthand field Fixes rust-lang#118145
Update cargo 7 commits in 9b13310ca596020a737aaa47daa4ed9ff8898a2f..26333c732095d207aa05932ce863d850fb309386 2023-11-24 16:20:51 +0000 to 2023-11-28 20:07:39 +0000 - docs: link to the packages lint table from the related workspace table (rust-lang/cargo#13057) - Add more doc comments for gc changes. (rust-lang/cargo#13055) - docs: Provide pointers for MSRV (rust-lang/cargo#13056) - Fixed typo in SemVer Compatibility documentation page (rust-lang/cargo#13054) - refactor: use custom error instead of anyhow (rust-lang/cargo#13050) - review and remove ignored tests in rustfix (rust-lang/cargo#13047) - docs: add doc comments for rustfix (rust-lang/cargo#13048) r? ghost
…errors Fix a typo in a `format_args!` note
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=7 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: f440b5f0ea In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (e9b7bf0): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.352s -> 673.972s (-0.06%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
!for path in function call if it has generic args #118342 (Dont suggest!for path in function call if it has generic args)rustc_ast_loweringcleanups #118401 (rustc_ast_loweringcleanups)fn position, as it always returns Some #118409 (format_foreign.rs: unwrap return Option value forfn position, as it always returns Some)format_args!note #118429 (Fix a typo in aformat_args!note)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup