Skip to content

Fix ICE: fn_arg_names: unexpected item DefId(..) #118526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2023
Merged

Fix ICE: fn_arg_names: unexpected item DefId(..) #118526

merged 1 commit into from
Dec 3, 2023
+45 −2

Conversation

sjwang05
Copy link
Contributor

@sjwang05 sjwang05 commented Dec 2, 2023

Fixes #118510

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2023
sjwang05
sjwang05 commented Dec 2, 2023
View reviewed changes
petrochenkov
petrochenkov reviewed Dec 2, 2023
View reviewed changes
compiler-errors
compiler-errors approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that would make the error message better

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
@sjwang05
Copy link
Contributor Author

sjwang05 commented Dec 2, 2023

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2023
@petrochenkov
Copy link
Contributor

r=me after squashing the changes into one commit and giving that commit a more descriptive message.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
@sjwang05
Copy link
Contributor Author

sjwang05 commented Dec 2, 2023

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2023

📌 Commit a2171fe has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2023
@bors
Copy link
Collaborator

bors commented Dec 3, 2023

⌛ Testing commit a2171fe with merge 21d88b3...

@bors
Copy link
Collaborator

bors commented Dec 3, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 21d88b3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2023
@bors bors merged commit 21d88b3 into rust-lang:master Dec 3, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (21d88b3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)		 -3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.8% [-3.8%, -3.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.398s -> 672.859s (-0.08%)
Artifact size: 314.08 MiB -> 314.10 MiB (0.01%)

@sjwang05 sjwang05 deleted the issue-118510 branch January 16, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

ICE: fn_arg_names: unexpected item DefId(..)
6 participants
@sjwang05 @rustbot @petrochenkov @bors @rust-timer @compiler-errors