Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser ICE from attrs #118542

Merged
merged 1 commit into from Dec 3, 2023
Merged

Fix parser ICE from attrs #118542

merged 1 commit into from Dec 3, 2023
+110 −12

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Dec 2, 2023 •
edited

Fixes #118531,
Fixes #118530.

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2023
@cjgillot
Copy link
Contributor

cjgillot commented Dec 2, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 2, 2023

📌 Commit 5ff428c has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
@bors
Copy link
Contributor

bors commented Dec 3, 2023

⌛ Testing commit 5ff428c with merge 225e36c...

@bors
Copy link
Contributor

bors commented Dec 3, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 225e36c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2023
@bors bors merged commit 225e36c into rust-lang:master Dec 3, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 3, 2023
@bors bors mentioned this pull request Dec 3, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (225e36c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [0.1%, 3.6%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.6% [0.1%, 3.6%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.446s -> 672.67s (0.03%)
Artifact size: 314.11 MiB -> 314.11 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

ICE: attrs: None at diagnostics.rs:804:30 ICE: attrs: None at diagnostics.rs:791:52
5 participants
@chenyukang @rustbot @cjgillot @bors @rust-timer