Skip to content

Conversation

lqd
Copy link
Member

@lqd lqd commented Dec 16, 2023

This PR:

  • removes the unstable linker flavors from the stable documentation
  • documents the unstable -C linker-flavor values in the unstable book (including the ones previously described as stable)
  • documents the unstable -C link-self-contained components in the unstable book

I don't know if these have some common reviewers, but if not r? @petrochenkov as the most knowledgeable person in this area. Please feel free to reassign, I know that you are quite busy.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 16, 2023
@petrochenkov
Copy link
Contributor

r=me with #119024 (comment) addressed.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2023
@lqd
Copy link
Member Author

lqd commented Dec 18, 2023

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Dec 18, 2023

📌 Commit 3006e62 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2023
@bors
Copy link
Collaborator

bors commented Dec 18, 2023

⌛ Testing commit 3006e62 with merge 2a76340...

@bors
Copy link
Collaborator

bors commented Dec 18, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 2a76340 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 18, 2023
@bors bors merged commit 2a76340 into rust-lang:master Dec 18, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 18, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2a76340): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% [0.5%, 0.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.8%, 0.8%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.8%, 0.8%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.256s -> 673.958s (0.10%)
Artifact size: 312.47 MiB -> 312.41 MiB (-0.02%)

@lqd lqd deleted the linker-docs branch December 18, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants