Skip to content

Subtree sync for rustc_codegen_cranelift #119278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 24, 2023
Merged

Subtree sync for rustc_codegen_cranelift #119278

merged 13 commits into from
Dec 24, 2023

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 24, 2023

This implements simd_masked_store and fixes two borked subtree syncs that forgot to sync back some changes to the rust repo.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

bjorn3 and others added 13 commits December 19, 2023 12:46
@bjorn3
Merge commit '3a9bf729322fb5035518f99b9d76a742bf7c124e' into sync_cg_…
a4be90e 
…clif-2023-12-19
@bjorn3
Merge branch 'sync_from_rust'
c7b4e03
@bjorn3
Implement simd_masked_store
dab8395
@pietroalbini
update cfg(bootstrap)s
71899c3
@bjorn3
Update Cranelift to 0.103
3847a01
@bjorn3
Ignore a rustc test that needs LTO support
e935766
@bjorn3
Disable a rustc test that depends on -Cpanic=unwind
289a274
@nnethercote
Rename EarlyDiagCtxt methods to match DiagCtxt.
b94a2a1 
- `early_error_no_abort` -> `early_err`
- `early_error` -> `early_fatal`
- `early_struct_error` -> `early_struct_fatal`
@compiler-errors
Rollup merge of rust-lang#119171 - nnethercote:cleanup-errors-4, r=co…
bfda19d 
…mpiler-errors

Cleanup error handlers: round 4

More `rustc_errors` cleanups. A sequel to rust-lang#118933.

r? `@compiler-errors`
@bjorn3
Sync from rust 2d7be73
23e26ca
@bjorn3
Rustup to rustc 1.77.0-nightly (2d7be73 2023-12-23)
26c02eb
@bjorn3
Merge commit '26c02eb2904da9a53d2220d4f3069b19a3c81d3d' into sync_cg_…
4b854ef 
…clif-2023-12-24
@bjorn3
Fix borked subtree syncs
bc1f3f5
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 24, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend labels Dec 24, 2023
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 24, 2023

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Dec 24, 2023

📌 Commit bc1f3f5 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 24, 2023
@bjorn3 bjorn3 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2023
@bjorn3 bjorn3 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 24, 2023
@bjorn3 bjorn3 mentioned this pull request Dec 24, 2023
Closed
This was linked to issues Dec 24, 2023
std::simd scatter miscompilation rust-lang/rustc_codegen_cranelift#1439
Closed
Fix mismatch between mini_core_hello_world.rs in this repo and the rust repo rust-lang/rustc_codegen_cranelift#1385
Closed
@bors
Copy link
Collaborator

bors commented Dec 24, 2023

⌛ Testing commit bc1f3f5 with merge f736079...

@bors
Copy link
Collaborator

bors commented Dec 24, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing f736079 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 24, 2023
@bors bors merged commit f736079 into rust-lang:master Dec 24, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 24, 2023
@bjorn3 bjorn3 deleted the sync_cg_clif-2023-12-24 branch December 24, 2023 19:26
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f736079): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.8%, 0.9%] 3
Regressions ❌
(secondary)		 0.5% [0.3%, 0.7%] 20
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.9% [0.8%, 0.9%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% [-3.6%, -1.2%] 3
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) -2.6% [-3.6%, -1.2%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 670.392s -> 670.109s (-0.04%)
Artifact size: 312.52 MiB -> 312.63 MiB (0.03%)

@rustbot rustbot added the perf-regression Performance regression. label Dec 24, 2023
@Kobzol
Copy link
Member

Kobzol commented Dec 26, 2023

This is the helloworld/small crate noise that has been appearing recently.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

std::simd scatter miscompilation Fix mismatch between mini_core_hello_world.rs in this repo and the rust repo
8 participants
@bjorn3 @rustbot @bors @rust-timer @Kobzol @pietroalbini @nnethercote @compiler-errors