Make intrinsics::assume const stable
#119583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rust-lang#76972 Blocks rust-lang#119452 Approved in rust-lang#119452 (comment)
rustbot
added
S-waiting-on-review
|
The intrinsic itself is still unstable so it can't be called from stable code; this just affects whether stable const fn inside core/std can call this intrinsic. LGTM! @bors r+ rollup |
bors
added
S-waiting-on-bors
There is a test for this, right? Just double checking. |
|
It's a regular unstable intrinsic. I don't think we need a test for each unstable intrinsic that it can't be called from stable. Whether we have a test for the general situation of "unstable but const-stable item", I do not know. The machinery for that is not new. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2024
…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#119034 (Allow coverage tests to ignore test modes, and to enable color in coverage reports) - rust-lang#119148 (Tweak suggestions for bare trait used as a type) - rust-lang#119538 (Cleanup error handlers: round 5) - rust-lang#119566 (Remove `-Zdump-mir-spanview`) - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.) - rust-lang#119577 (Migrate memory overlap check from validator to lint) - rust-lang#119583 (Make `intrinsics::assume` const stable) - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature) - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table) - rust-lang#119601 (`Emitter` cleanups) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 5, 2024
Rollup merge of rust-lang#119583 - AngelicosPhosphoros:const_assume, r=RalfJung Make `intrinsics::assume` const stable Closes rust-lang#76972 Blocks rust-lang#119452 Approved in rust-lang#119452 (comment) r? `@RalfJung`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76972
Blocks #119452
Approved in #119452 (comment)
r? @RalfJung