Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an ICE that occurs after an error has already been reported #119772

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix an ICE that occurs after an error has already been reported #119772

merged 1 commit into from
Jan 10, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 9, 2024

fixes #117491

cc @jswrenn

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2024

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2024
compiler-errors
compiler-errors approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 9, 2024

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jan 9, 2024

📌 Commit 4f0869e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2024
@bors
Auto merge of rust-lang#119797 - matthiaskrgr:rollup-nn2lt39, r=matth…
e927184 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#106893 (Explain base expression for struct update syntax)
 - rust-lang#119769 (rustdoc: offset generic args of cross-crate trait object types when cleaning)
 - rust-lang#119772 (Fix an ICE that occurs after an error has already been reported)
 - rust-lang#119782 (rint intrinsics: caution against actually trying to check for floating-point exceptions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4571ef9 into rust-lang:master Jan 10, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2024
@rust-timer
Unrolled build for rust-lang#119772
61dd7f0 
Rollup merge of rust-lang#119772 - oli-obk:whackamole, r=compiler-errors

Fix an ICE that occurs after an error has already been reported

fixes rust-lang#117491

cc `@jswrenn`
@oli-obk oli-obk deleted the whackamole branch January 10, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

ICE: transmute: not implemented: Cycle
5 participants
@oli-obk @rustbot @bors @compiler-errors @cjgillot