Validate AggregateKind types in MIR #120137

compiler-errors · 2024-01-19T19:48:04Z

Would have helped me catch some bugs when writing shims for async closures

rustbot · 2024-01-19T19:48:13Z

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2024-01-19T19:48:19Z

If perf is bad, I'll put this behind a debug cfg I guess

@bors try @rust-timer queue

bors · 2024-01-19T19:49:28Z

⌛ Trying commit f26f52c with merge 3dba895...

… r=<try> Validate AggregateKind types in MIR Would have helped me catch some bugs when writing shims for async closures

bors · 2024-01-19T21:15:05Z

☀️ Try build successful - checks-actions
Build commit: 3dba895 (3dba895c5cdaaf8d6e129e96f6a9f9bd65a3b09b)

rust-timer · 2024-01-19T23:04:26Z

Finished benchmarking commit (3dba895): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	2
All ❌✅ (primary)	-1.3%	[-1.3%, -1.3%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 664.714s -> 664.328s (-0.06%)
Artifact size: 308.27 MiB -> 308.25 MiB (-0.01%)

nnethercote

More checking is good. r=me, I'll let you decide how to address the suggestions.

@bors delegate=compiler-errors rollup

nnethercote · 2024-01-21T21:05:58Z

compiler/rustc_const_eval/src/transform/validate.rs

+                AggregateKind::Tuple => {}
+                AggregateKind::Array(dest) => {
+                    for src in fields {
+                        if !self.mir_assign_valid_types(src.ty(self.body, self.tcx), dest) {


Note: this is a weird name for a method returning bool.

(But pre-existing, so no need to change anything in this PR.)

I will not change it in that case 😅

nnethercote · 2024-01-21T21:15:09Z

compiler/rustc_const_eval/src/transform/validate.rs

+                        }
+                    }
+                }
+                AggregateKind::Coroutine(_, args) => {


Seems like the Closure and Coroutine branches could be merged, the types are the same. Only the error message differs, but it could be changed to "closure/coroutine field has the wrong type".

No, they differ with how they handle their args. See the as_coroutine and as_closure.

nnethercote · 2024-01-21T21:44:00Z

@bors delegate=compiler-errors rollup

bors · 2024-01-21T21:44:04Z

✌️ @compiler-errors, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

compiler-errors · 2024-01-21T21:45:35Z

I don't need delegation since I already have bors rights 😉

@bors r=nnethercote

bors · 2024-01-21T21:45:38Z

📌 Commit f26f52c has been approved by nnethercote

It is now in the queue for this repository.

…s, r=nnethercote Validate AggregateKind types in MIR Would have helped me catch some bugs when writing shims for async closures

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#117910 (Refactor uses of `objc_msgSend` to no longer have clashing definitions) - rust-lang#118639 (Undeprecate lint `unstable_features` and make use of it in the compiler) - rust-lang#119801 (Fix deallocation with wrong allocator in (A)Rc::from_box_in) - rust-lang#120058 (bootstrap: improvements for compiler builds) - rust-lang#120059 (Make generic const type mismatches not hide trait impls from the trait solver) - rust-lang#120097 (Report unreachable subpatterns consistently) - rust-lang#120137 (Validate AggregateKind types in MIR) - rust-lang#120164 (`maybe_lint_impl_trait`: separate `is_downgradable` from `is_object_safe`) - rust-lang#120181 (Allow any `const` expression blocks in `thread_local!`) - rust-lang#120204 (Builtin macros effectively have implicit #[collapse_debuginfo(yes)]) - rust-lang#120218 (rustfmt: Check that a token can begin a nonterminal kind before parsing it as a macro arg) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#117910 (Refactor uses of `objc_msgSend` to no longer have clashing definitions) - rust-lang#118639 (Undeprecate lint `unstable_features` and make use of it in the compiler) - rust-lang#119801 (Fix deallocation with wrong allocator in (A)Rc::from_box_in) - rust-lang#120058 (bootstrap: improvements for compiler builds) - rust-lang#120059 (Make generic const type mismatches not hide trait impls from the trait solver) - rust-lang#120097 (Report unreachable subpatterns consistently) - rust-lang#120137 (Validate AggregateKind types in MIR) - rust-lang#120164 (`maybe_lint_impl_trait`: separate `is_downgradable` from `is_object_safe`) - rust-lang#120181 (Allow any `const` expression blocks in `thread_local!`) - rust-lang#120218 (rustfmt: Check that a token can begin a nonterminal kind before parsing it as a macro arg) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#120137 - compiler-errors:validate-aggregates, r=nnethercote Validate AggregateKind types in MIR Would have helped me catch some bugs when writing shims for async closures

Validate AggregateKind types in MIR

f26f52c

rustbot assigned davidtwco Jan 19, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 19, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2024

Auto merge of rust-lang#120137 - compiler-errors:validate-aggregates,…

3dba895

… r=<try> Validate AggregateKind types in MIR Would have helped me catch some bugs when writing shims for async closures

This comment was marked as duplicate.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 19, 2024

nnethercote reviewed Jan 21, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2024

matthiaskrgr mentioned this pull request Jan 22, 2024

Rollup of 11 pull requests #120237

Closed

matthiaskrgr mentioned this pull request Jan 22, 2024

Rollup of 10 pull requests #120242

Merged

bors merged commit a12e2ff into rust-lang:master Jan 22, 2024
12 checks passed

rustbot added this to the 1.77.0 milestone Jan 22, 2024

matthiaskrgr mentioned this pull request Jan 23, 2024

ice: broken mir: {type error} #120253

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate AggregateKind types in MIR #120137

Validate AggregateKind types in MIR #120137

compiler-errors commented Jan 19, 2024

rustbot commented Jan 19, 2024

compiler-errors commented Jan 19, 2024 •

edited

This comment has been minimized.

bors commented Jan 19, 2024

This comment was marked as duplicate.

bors commented Jan 19, 2024

This comment has been minimized.

rust-timer commented Jan 19, 2024

nnethercote left a comment •

edited

nnethercote Jan 21, 2024

nnethercote Jan 21, 2024

compiler-errors Jan 21, 2024

nnethercote Jan 21, 2024

compiler-errors Jan 21, 2024

nnethercote commented Jan 21, 2024

bors commented Jan 21, 2024

compiler-errors commented Jan 21, 2024

bors commented Jan 21, 2024

Validate AggregateKind types in MIR #120137

Validate AggregateKind types in MIR #120137

Conversation

compiler-errors commented Jan 19, 2024

rustbot commented Jan 19, 2024

compiler-errors commented Jan 19, 2024 • edited

This comment has been minimized.

bors commented Jan 19, 2024

This comment was marked as duplicate.

bors commented Jan 19, 2024

This comment has been minimized.

rust-timer commented Jan 19, 2024

Overall result: ❌ regressions - no action needed

nnethercote left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nnethercote commented Jan 21, 2024

bors commented Jan 21, 2024

compiler-errors commented Jan 21, 2024

bors commented Jan 21, 2024

compiler-errors commented Jan 19, 2024 •

edited

nnethercote left a comment •

edited