Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update host LLVM on x64 Linux to LLVM 18 #120985

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 12, 2024

Updates host LLVM on Linux to 18.1.0.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 12, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 12, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2024
Update host LLVM on x64 Linux to LLVM 18

Opening for a perf. run.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Feb 12, 2024

⌛ Trying commit 2c1c32c with merge a9e95dc...

@bors
Copy link
Contributor

bors commented Feb 12, 2024

☀️ Try build successful - checks-actions
Build commit: a9e95dc (a9e95dc1788a46dd26c32030c556b83fdb610b4d)

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 12, 2024

☀️ Try build successful - checks-actions
Build commit: a9e95dc (a9e95dc1788a46dd26c32030c556b83fdb610b4d)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a9e95dc): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.9%] 110
Regressions ❌
(secondary)
0.3% [0.2%, 0.5%] 39
Improvements ✅
(primary)
-0.8% [-1.4%, -0.4%] 35
Improvements ✅
(secondary)
-0.8% [-1.2%, -0.5%] 5
All ❌✅ (primary) 0.1% [-1.4%, 0.9%] 145

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-0.9%, -0.7%] 6
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.8% [-0.9%, -0.7%] 6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 664.301s -> 659.619s (-0.70%)
Artifact size: 308.35 MiB -> 308.27 MiB (-0.03%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 13, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 13, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 13, 2024
@bors
Copy link
Contributor

bors commented Feb 13, 2024

⌛ Trying commit 2c1c32c with merge b9b934a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2024
Update host LLVM on x64 Linux to LLVM 18

Opening for a perf. run.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Feb 14, 2024

☀️ Try build successful - checks-actions
Build commit: b9b934a (b9b934ac3a6bbe68b210bcadd2c6ba8366a8fe22)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b9b934a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 1.0%] 102
Regressions ❌
(secondary)
0.4% [0.2%, 1.0%] 44
Improvements ✅
(primary)
-0.9% [-1.2%, -0.3%] 44
Improvements ✅
(secondary)
-0.9% [-2.3%, -0.6%] 14
All ❌✅ (primary) -0.0% [-1.2%, 1.0%] 146

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-2.8%, 2.0%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
-1.3% [-4.0%, -0.7%] 6
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.3% [-4.0%, -0.7%] 6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.588s -> 627.455s (-0.18%)
Artifact size: 305.10 MiB -> 306.76 MiB (0.54%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2024
@Kobzol Kobzol marked this pull request as ready for review March 8, 2024 07:39
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 8, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2024
Update host LLVM on x64 Linux to LLVM 18

Opening for a perf. run.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Mar 8, 2024

⌛ Trying commit aba3890 with merge d409810...

@bors
Copy link
Contributor

bors commented Mar 8, 2024

☀️ Try build successful - checks-actions
Build commit: d409810 (d409810d5c78dbb654d5d193baa2d25fff194119)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d409810): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.9%] 88
Regressions ❌
(secondary)
0.3% [0.1%, 0.5%] 31
Improvements ✅
(primary)
-1.0% [-1.7%, -0.2%] 56
Improvements ✅
(secondary)
-1.1% [-2.9%, -0.8%] 22
All ❌✅ (primary) -0.2% [-1.7%, 0.9%] 144

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-0.7%, -0.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.7% [-0.7%, -0.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.506s -> 643.827s (-0.41%)
Artifact size: 172.55 MiB -> 172.09 MiB (-0.27%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 8, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 8, 2024

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit aba3890 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@bors
Copy link
Contributor

bors commented Mar 9, 2024

⌛ Testing commit aba3890 with merge 25ee3c6...

@bors
Copy link
Contributor

bors commented Mar 9, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 25ee3c6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 9, 2024
@bors bors merged commit 25ee3c6 into rust-lang:master Mar 9, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 9, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (25ee3c6): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.1%, 1.0%] 88
Regressions ❌
(secondary)
0.4% [0.1%, 0.5%] 21
Improvements ✅
(primary)
-1.0% [-1.6%, -0.4%] 54
Improvements ✅
(secondary)
-0.8% [-1.2%, -0.6%] 8
All ❌✅ (primary) -0.2% [-1.6%, 1.0%] 142

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.585s -> 647.693s (-0.44%)
Artifact size: 310.34 MiB -> 310.09 MiB (-0.08%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants