Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tidy check for .stderr/.stdout files for non-existent test revisions #121475

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Add tidy check for .stderr/.stdout files for non-existent test revisions #121475

merged 2 commits into from
Mar 1, 2024

Conversation

jieyouxu
Copy link
Contributor

Closes #77498.

@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 22, 2024

📌 Commit ba0bd9b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2024
@the8472
Copy link
Member

the8472 commented Feb 22, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2024
@jieyouxu jieyouxu force-pushed the tidy-stderr-check branch 4 times, most recently from 021b20c to fa28a8c Compare February 23, 2024 23:08
@jieyouxu
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2024
@the8472 the8472 self-assigned this Feb 25, 2024
@compiler-errors
Copy link
Member

r? the8472

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2024

Could not assign reviewer from: the8472.
User(s) the8472 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@compiler-errors compiler-errors removed their assignment Feb 29, 2024
@the8472
Copy link
Member

the8472 commented Feb 29, 2024

@bors r=the8472,compiler-errors

@bors
Copy link
Contributor

bors commented Feb 29, 2024

📌 Commit 19ee457 has been approved by the8472,compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 1, 2024
@workingjubilee
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
129dc66 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
@workingjubilee workingjubilee mentioned this pull request Mar 1, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#121834 - workingjubilee:rollup-k9kpbkm, r=wor…
04d9efd 
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#117156 (Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits)
 - rust-lang#119199 (Add arm64ec-pc-windows-msvc target)
 - rust-lang#120468 (Add a new `wasm32-wasip1` target to rustc)
 - rust-lang#120504 (Vec::try_with_capacity)
 - rust-lang#121416 (Improve error messages for generics with default parameters)
 - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions)
 - rust-lang#121736 (Remove `Mutex::unlock` Function)
 - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block)
 - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 1, 2024
@workingjubilee
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
b4add6e 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
@workingjubilee workingjubilee mentioned this pull request Mar 1, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#121836 - workingjubilee:rollup-vrtx5t9, r=wor…
18d5c6f 
…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117156 (Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits)
 - rust-lang#119199 (Add arm64ec-pc-windows-msvc target)
 - rust-lang#120468 (Add a new `wasm32-wasip1` target to rustc)
 - rust-lang#121416 (Improve error messages for generics with default parameters)
 - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions)
 - rust-lang#121736 (Remove `Mutex::unlock` Function)
 - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block)
 - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
f8cb5af 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 1, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
a41f73b 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 1, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#121845 - matthiaskrgr:rollup-7q4bzuc, r=matth…
6346613 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#119199 (Add arm64ec-pc-windows-msvc target)
 - rust-lang#121416 (Improve error messages for generics with default parameters)
 - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions)
 - rust-lang#121736 (Remove `Mutex::unlock` Function)
 - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrte check)
 - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block)
 - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`)
 - rust-lang#121819 (Handle stashing of delayed bugs)
 - rust-lang#121828 (Remove unused fluent messages)
 - rust-lang#121831 (Fix typo in comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 1, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8…
dbfbd71 
…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#121854 - matthiaskrgr:rollup-uulg3t8, r=matth…
1a134d8 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119199 (Add arm64ec-pc-windows-msvc target)
 - rust-lang#121416 (Improve error messages for generics with default parameters)
 - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions)
 - rust-lang#121736 (Remove `Mutex::unlock` Function)
 - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block)
 - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`)
 - rust-lang#121819 (Handle stashing of delayed bugs)
 - rust-lang#121828 (Remove unused fluent messages)
 - rust-lang#121831 (Fix typo in comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 1, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@bors
Auto merge of rust-lang#121859 - matthiaskrgr:rollup-i724wpm, r=matth…
2dceda4 
…iaskrgr

Rollup of 12 pull requests

Successful merges:

 - rust-lang#120646 (Fix incorrect suggestion for uninitialized binding in pattern)
 - rust-lang#121416 (Improve error messages for generics with default parameters)
 - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions)
 - rust-lang#121580 (make unused_imports less assertive in test modules)
 - rust-lang#121736 (Remove `Mutex::unlock` Function)
 - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block)
 - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`)
 - rust-lang#121819 (Handle stashing of delayed bugs)
 - rust-lang#121828 (Remove unused fluent messages)
 - rust-lang#121831 (Fix typo in comment)
 - rust-lang#121850 (Make `ZeroablePrimitive` trait unsafe.)
 - rust-lang#121853 (normalizes-to: handle negative impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dcde08f into rust-lang:master Mar 1, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2024
@rust-timer
Unrolled build for rust-lang#121475
0e1373a 
Rollup merge of rust-lang#121475 - jieyouxu:tidy-stderr-check, r=the8472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.
@RalfJung
Copy link
Member

RalfJung commented Mar 4, 2024

I think something isn't right with this check: #121986

@jieyouxu jieyouxu deleted the tidy-stderr-check branch March 9, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 left review comments

@fmease fmease fmease left review comments

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@the8472 the8472

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

compiletest should remove .stderr for nonexistent revisions
8 participants
@jieyouxu @rustbot @rust-log-analyzer @compiler-errors @bors @the8472 @RalfJung @fmease