Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

By changing some attributes to only_local, reducing encoding attributes in the crate metadate. #121493

Merged
merged 1 commit into from
Feb 26, 2024
Merged

By changing some attributes to only_local, reducing encoding attributes in the crate metadate. #121493

merged 1 commit into from
Feb 26, 2024

Conversation

surechen
Copy link
Contributor

Thank you.
This is part of changing attributes to only_local. I hope get your opinion whether I should split into multiple PRs, or submit in one.

According to try to not rely on attributes from extern crates and lcnr's guidance.

@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2024

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 23, 2024
@surechen
Copy link
Contributor Author

r?

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned oli-obk Feb 23, 2024
@lcnr
Copy link
Contributor

lcnr commented Feb 23, 2024

automatically_derived seems to be used by clippy. Either revert that change or add it to ImplTraitHeader and modify clippy to access that instead

@surechen
Copy link
Contributor Author

automatically_derived seems to be used by clippy. Either revert that change or add it to ImplTraitHeader and modify clippy to access that instead

Thank you, I want to restore it first. In this PR, I want to deal with the simplest situation of adding tags first, and then submit other PRs for situations where modifing other code is required.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@surechen
By changing some attributes to only_local, reducing encoding attribut…
ccf789b 
…es in the crate metadate.

Thank you.
This is part of changing attributes to only_local. I hope get your opinion  whether I should split into multiple PRs, or submit in one.

According to [try to not rely on attributes from extern crates](rust-lang/compiler-team#505) and lcnr's guidance.
@lcnr
Copy link
Contributor

lcnr commented Feb 26, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2024
@bors
Copy link
Contributor

bors commented Feb 26, 2024

⌛ Trying commit ccf789b with merge 87d28ff...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2024
@bors
Auto merge of rust-lang#121493 - surechen:edit_attribute_only_local, …
87d28ff 
…r=<try>

By changing some attributes to only_local, reducing encoding attributes in the crate metadate.

Thank you.
This is part of changing attributes to only_local. I hope get your opinion  whether I should split into multiple PRs, or submit in one.

According to [try to not rely on attributes from extern crates](rust-lang/compiler-team#505) and lcnr's guidance.
@bors
Copy link
Contributor

bors commented Feb 26, 2024

☀️ Try build successful - checks-actions
Build commit: 87d28ff (87d28ff5835a5e075ce0fa404c710415d0c76903)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (87d28ff): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.9% [2.1%, 5.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.341s -> 651.216s (0.13%)
Artifact size: 311.22 MiB -> 311.21 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2024
@lcnr
Copy link
Contributor

lcnr commented Feb 26, 2024

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Feb 26, 2024

📌 Commit ccf789b has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 26, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2024
@bors
Auto merge of rust-lang#121636 - matthiaskrgr:rollup-1tt2o5n, r=matth…
829308e 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#121389 (llvm-wrapper: fix few warnings)
 - rust-lang#121493 (By changing some attributes to only_local, reducing encoding attributes in the crate metadate.)
 - rust-lang#121615 (Move `emit_stashed_diagnostic` call in rustfmt.)
 - rust-lang#121617 (Actually use the right closure kind when checking async Fn goals)
 - rust-lang#121628 (Do not const prop unions)
 - rust-lang#121629 (fix some references to no-longer-existing ReprOptions.layout_seed)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6e3ece3 into rust-lang:master Feb 26, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 26, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2024
@rust-timer
Unrolled build for rust-lang#121493
d7fefaa 
Rollup merge of rust-lang#121493 - surechen:edit_attribute_only_local, r=lcnr

By changing some attributes to only_local, reducing encoding attributes in the crate metadate.

Thank you.
This is part of changing attributes to only_local. I hope get your opinion  whether I should split into multiple PRs, or submit in one.

According to [try to not rely on attributes from extern crates](rust-lang/compiler-team#505) and lcnr's guidance.
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Jun 22, 2024
@bors
Auto merge of rust-lang#121636 - matthiaskrgr:rollup-1tt2o5n, r=matth…
f9dba39 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#121389 (llvm-wrapper: fix few warnings)
 - rust-lang#121493 (By changing some attributes to only_local, reducing encoding attributes in the crate metadate.)
 - rust-lang#121615 (Move `emit_stashed_diagnostic` call in rustfmt.)
 - rust-lang#121617 (Actually use the right closure kind when checking async Fn goals)
 - rust-lang#121628 (Do not const prop unions)
 - rust-lang#121629 (fix some references to no-longer-existing ReprOptions.layout_seed)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
7 participants
@surechen @rustbot @lcnr @rust-log-analyzer @rust-timer @bors @oli-obk